[Buildbot-commits] buildbot ChangeLog,1.720,1.721

[Brian Warner]

Update of /cvsroot/buildbot/buildbot
In directory sc8-pr-cvs3.sourceforge.net:/tmp/cvs-serv25199

Modified Files:
	ChangeLog 
Log Message:
[project @ make 'stdio' log come first, refactor setupLogfiles]

Original author: warner at lothar.com
Date: 2006-08-25 21:48:58

Index: ChangeLog
===================================================================
RCS file: /cvsroot/buildbot/buildbot/ChangeLog,v
retrieving revision 1.720
retrieving revision 1.721
diff -u -d -r1.720 -r1.721
--- ChangeLog	24 Aug 2006 10:05:15 -0000	1.720
+++ ChangeLog	25 Aug 2006 21:54:43 -0000	1.721
@@ -1,3 +1,23 @@
+2006-08-25  Brian Warner  <warner at lothar.com>
+
+	* buildbot/process/step.py (LoggingBuildStep.startCommand): set up
+	all logfiles= in startCommand(), rather than in start() . This
+	makes it easier to have the 'stdio' log come before any secondary
+	logfiles, which I feel makes the waterfall display more
+	understandable.
+	(LoggingBuildStep.setupLogfiles): move the addLog/cmd.useLog code
+	from ShellCommand up into LoggingBuildStep
+	(LoggingBuildStep.__init__): move the handling of logfiles= from
+	ShellCommand up to LoggingBuildStep, because startCommand is
+	provided by LoggingBuildStep, whereas start() was specific to
+	subclasses like ShellCommand and Source. This removes code
+	duplication in those subclasses.
+	(ShellCommand.__init__): same
+	(ShellCommand.checkForOldSlaveAndLogfiles): split out the check
+	for a slave that's too old to understand logfiles= into a separate
+	method, so it can live in ShellCommand. The rest of
+	setupLogfiles() can live in LoggingBuildStep.
+
 2006-08-24  Brian Warner  <warner at lothar.com>
 
 	* buildbot/locks.py (BaseLock): you can now configure Locks to