[Buildbot-commits] buildbot ChangeLog,1.713,1.714

Brian Warner warner at users.sourceforge.net
Mon Aug 21 03:38:06 UTC 2006


Update of /cvsroot/buildbot/buildbot
In directory sc8-pr-cvs3.sourceforge.net:/tmp/cvs-serv8420

Modified Files:
	ChangeLog 
Log Message:
[project @ PBChangeSource.prefix= : fix and simplify, just do a string comparison]
This effectively resolves SF#1217699 and SF#1381867

Original author: warner at lothar.com
Date: 2006-08-21 03:36:38

Index: ChangeLog
===================================================================
RCS file: /cvsroot/buildbot/buildbot/ChangeLog,v
retrieving revision 1.713
retrieving revision 1.714
diff -u -d -r1.713 -r1.714
--- ChangeLog	21 Aug 2006 03:37:50 -0000	1.713
+++ ChangeLog	21 Aug 2006 03:38:04 -0000	1.714
@@ -1,5 +1,23 @@
 2006-08-20  Brian Warner  <warner at lothar.com>
 
+	* buildbot/changes/pb.py (PBChangeSource): fix and simplify
+	meaning of the prefix= argument. It is now just a string which is
+	stripped from the beginning of the filename. If prefix= is set but
+	not found on any given filename, that filename is ignored. If all
+	filenames in a Change are ignored, the Change is dropped. This is
+	much simpler than the previous sep= nonsense, and I should have
+	implemented it this way from the beginning. Effectively resolves
+	SF#1217699 and SF#1381867. Thanks to Gary Granger and Marius
+	Gedminas for the catch and suggested fixes.
+	(ChangePerspective.perspective_addChange): implement the actual
+	prefix comparison
+	* buildbot/test/test_changes.py (TestChangePerspective): test it
+	* docs/buildbot.texinfo (PBChangeSource): document it, explain
+	how to properly use prefix=
+	* docs/examples/twisted_master.cfg (source): update prefix= by
+	adding the trailing slash
+
+
 	* docs/examples/twisted_master.cfg: update to actual practice
 
 	* buildbot/test/test_web.py (WaterfallSteps.test_urls): oops,





More information about the Commits mailing list