[Buildbot-commits] buildbot/buildbot/slave commands.py,1.43,1.44

[Brian Warner]

Update of /cvsroot/buildbot/buildbot/buildbot/slave
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv23634/buildbot/slave

Modified Files:
	commands.py 
Log Message:
Revision: arch at buildbot.sf.net--2004/buildbot--dev--0--patch-500
Creator:  Brian Warner <warner at lothar.com>

fix process_twisted.py factories, other style changes

	* all: use isinstance() instead of 'type(x) is foo', suggested by
	Neal Norwitz

	* buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
	oops, fix a brain-fade from the other week, when making the
	addStep changes. I changed all the __init__ upcalls to use the
	wrong superclass name.
	(FullTwistedBuildFactory.__init__): same
	(TwistedDebsBuildFactory.__init__): same
	(TwistedReactorsBuildFactory.__init__): same
	(TwistedBuild.isFileImportant): use .startswith for clarity,
	thanks to Neal Norwitz for the suggestions.


Index: commands.py
===================================================================
RCS file: /cvsroot/buildbot/buildbot/buildbot/slave/commands.py,v
retrieving revision 1.43
retrieving revision 1.44
diff -u -d -r1.43 -r1.44
--- commands.py	11 Apr 2006 06:48:26 -0000	1.43
+++ commands.py	17 Apr 2006 19:22:34 -0000	1.44
@@ -484,7 +484,7 @@
         if type(rc) is not int:
             log.msg("weird, _abandonOnFailure was given rc=%s (%s)" % \
                     (rc, type(rc)))
-        assert type(rc) is int
+        assert isinstance(rc, int)
         if rc != 0:
             raise AbandonChain(rc)
         return rc