[Buildbot-commits] buildbot/buildbot interfaces.py,1.31,1.32

[Brian Warner]

Update of /cvsroot/buildbot/buildbot/buildbot
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv23210/buildbot

Modified Files:
	interfaces.py 
Log Message:
Revision: arch at buildbot.sf.net--2004/buildbot--dev--0--patch-309
Creator:  Brian Warner <warner at lothar.com>

update IBuilderStatus.getState signature

	* buildbot/interfaces.py (IBuilderStatus.getState): update
	signature, point out that 'build' can be None
	(IBuildStatus.getETA): point out ETA can be none

	* buildbot/status/html.py (CurrentBox.getBox): tolerate build/ETA
	being None
	* buildbot/status/words.py (IrcStatusBot.emit_status): same


Index: interfaces.py
===================================================================
RCS file: /cvsroot/buildbot/buildbot/buildbot/interfaces.py,v
retrieving revision 1.31
retrieving revision 1.32
diff -u -d -r1.31 -r1.32
--- interfaces.py	31 Aug 2005 01:51:41 -0000	1.31
+++ interfaces.py	1 Sep 2005 20:53:21 -0000	1.32
@@ -214,8 +214,9 @@
         """Return a tuple (state, build=None) for this Builder. 'state' is
         the so-called 'big-status', indicating overall status (as opposed to
         which step is currently running). It is a string, one of 'offline',
-        'idle', or 'building'. In the 'building' state, 'build' will be an
-        IBuildStatus object representing the current build."""
+        'idle', or 'building'. In the 'building' state, 'build' may be an
+        IBuildStatus object representing the current build (or None if the
+        Builder is in the pre-build ping-the-slave phase)."""
 
     def getSlave():
         """Return an ISlaveStatus object for the buildslave that is used by
@@ -349,7 +350,8 @@
 
     def getETA():
         """Returns the number of seconds from now in which the build is
-        expected to finish. This guess will be refined over time."""
+        expected to finish, or None if we can't make a guess. This guess will
+        be refined over time."""
 
     def getCurrentStep():
         """Return an IBuildStepStatus object representing the currently
@@ -471,7 +473,8 @@
 
     def getETA():
         """Returns the number of seconds from now in which the step is
-        expected to finish. This guess will be refined over time."""
+        expected to finish, or None if we can't make a guess. This guess will
+        be refined over time."""
 
     # Once you know the step has finished, the following methods are legal.
     # Before ths step has finished, they all return None.