[Buildbot-commits] buildbot/buildbot/status base.py,1.3,1.4

Brian Warner warner at users.sourceforge.net
Fri Oct 7 18:45:45 UTC 2005

Update of /cvsroot/buildbot/buildbot/buildbot/status
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv7377/buildbot/status

Modified Files:
Log Message:
Revision: arch at buildbot.sf.net--2004/buildbot--dev--0--patch-322
Creator:  Brian Warner <warner at lothar.com>

inherit from StatusReceiver properly

	* buildbot/slave/bot.py (SlaveBuilder.activity): survive
	bot.SlaveBuilder being disowned in the middle of a build

	* buildbot/status/base.py (StatusReceiverMultiService): oops, make
	this inherit from StatusReceiver. Also upcall in __init__. This
	fixes the embarrasing crash when the new buildSetSubmitted method
	is invoked and Waterfall/etc don't implement their own.
	* buildbot/test/test_run.py: add a TODO note about a test to catch
	just this sort of thing.

--This line, and those below, will be ignored--
Files to commit:
   <can't compute list>

This list might be incomplete or outdated if editing the log
message was not invoked from an up-to-date changes buffer!

Index: base.py
RCS file: /cvsroot/buildbot/buildbot/buildbot/status/base.py,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -d -r1.3 -r1.4
--- base.py	31 Aug 2005 08:04:36 -0000	1.3
+++ base.py	7 Oct 2005 18:45:42 -0000	1.4
@@ -58,12 +58,16 @@
     def builderRemoved(self, builderName):
-class StatusReceiverMultiService(service.MultiService, util.ComparableMixin):
+class StatusReceiverMultiService(StatusReceiver, service.MultiService,
+                                 util.ComparableMixin):
     if implements:
         __implements__ = IStatusReceiver, service.MultiService.__implements__
+    def __init__(self):
+        service.MultiService.__init__(self)
 class StatusReceiverPerspective(StatusReceiver, pbutil.NewCredPerspective):
     if implements:

More information about the Commits mailing list