[Buildbot-commits] buildbot/buildbot master.py,1.80,1.81

[Brian Warner]

Update of /cvsroot/buildbot/buildbot/buildbot
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv7377/buildbot

Modified Files:
	master.py 
Log Message:
Revision: arch at buildbot.sf.net--2004/buildbot--dev--0--patch-322
Creator:  Brian Warner <warner at lothar.com>

inherit from StatusReceiver properly

	* buildbot/slave/bot.py (SlaveBuilder.activity): survive
	bot.SlaveBuilder being disowned in the middle of a build

	* buildbot/status/base.py (StatusReceiverMultiService): oops, make
	this inherit from StatusReceiver. Also upcall in __init__. This
	fixes the embarrasing crash when the new buildSetSubmitted method
	is invoked and Waterfall/etc don't implement their own.
	* buildbot/test/test_run.py: add a TODO note about a test to catch
	just this sort of thing.

--This line, and those below, will be ignored--
Files to commit:
   <can't compute list>

This list might be incomplete or outdated if editing the log
message was not invoked from an up-to-date changes buffer!


Index: master.py
===================================================================
RCS file: /cvsroot/buildbot/buildbot/buildbot/master.py,v
retrieving revision 1.80
retrieving revision 1.81
diff -u -d -r1.80 -r1.81
--- master.py	17 Aug 2005 02:15:36 -0000	1.80
+++ master.py	7 Oct 2005 18:45:42 -0000	1.81
@@ -921,6 +921,8 @@
                                                          "\n".join(diffs)))
                     # TODO: if the basedir was changed, we probably need to
                     # make a new statusbag
+                    # TODO: if a slave is connected and we're re-using the
+                    # same slave, try to avoid a disconnect/reconnect cycle.
                     statusbag = old.builder_status
                     statusbag.saveYourself() # seems like a good idea
                     d = self.botmaster.removeBuilder(old)