[Buildbot-commits] buildbot ChangeLog,1.560,1.561

Brian Warner warner at users.sourceforge.net
Sun Nov 27 00:46:15 UTC 2005


Update of /cvsroot/buildbot/buildbot
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv3585

Modified Files:
	ChangeLog 
Log Message:
Revision: arch at buildbot.sf.net--2004/buildbot--dev--0--patch-444
Creator:  Brian Warner <warner at lothar.com>

fix StatusReceiver unsubscribe bug

	* buildbot/status/builder.py (BuildStepStatus.unsubscribe): make
	sure that unsubscribe works even if we never sent an ETA update.
	Also, don't explode on duplicate unsubscribe.
	(BuildStepStatus.addLog): make the convenience "return self"-added
	watcher automatically unsubscribe when the Step finishes.
	(BuildStatus.unsubscribe): same handle-duplicate-unsubscribe
	(BuildStatus.stepStarted): same auto-unsubscribe
	(BuilderStatus.buildStarted): same auto-unsubscribe

	* buildbot/interfaces.py (IStatusReceiver.buildStarted): document
	auto-unsubscribe
	(IStatusReceiver.stepStarted): same
	(IStatusReceiver.logStarted): same

	* buildbot/test/test_run.py (Status): move the Status test..
	* buildbot/test/test_status.py (Subscription): .. to here


Index: ChangeLog
===================================================================
RCS file: /cvsroot/buildbot/buildbot/ChangeLog,v
retrieving revision 1.560
retrieving revision 1.561
diff -u -d -r1.560 -r1.561
--- ChangeLog	26 Nov 2005 02:46:33 -0000	1.560
+++ ChangeLog	27 Nov 2005 00:46:13 -0000	1.561
@@ -1,3 +1,22 @@
+2005-11-26  Brian Warner  <warner at lothar.com>
+
+	* buildbot/status/builder.py (BuildStepStatus.unsubscribe): make
+	sure that unsubscribe works even if we never sent an ETA update.
+	Also, don't explode on duplicate unsubscribe.
+	(BuildStepStatus.addLog): make the convenience "return self"-added
+	watcher automatically unsubscribe when the Step finishes.
+	(BuildStatus.unsubscribe): same handle-duplicate-unsubscribe
+	(BuildStatus.stepStarted): same auto-unsubscribe
+	(BuilderStatus.buildStarted): same auto-unsubscribe
+
+	* buildbot/interfaces.py (IStatusReceiver.buildStarted): document
+	auto-unsubscribe
+	(IStatusReceiver.stepStarted): same
+	(IStatusReceiver.logStarted): same
+
+	* buildbot/test/test_run.py (Status): move the Status test..
+	* buildbot/test/test_status.py (Subscription): .. to here
+
 2005-11-25  Brian Warner  <warner at lothar.com>
 
 	* NEWS: more updates





More information about the Commits mailing list