[Buildbot-commits] buildbot/buildbot/changes freshcvs.py,1.20,1.21 pb.py,1.9,1.10

[Brian Warner]

Update of /cvsroot/buildbot/buildbot/buildbot/changes
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv14002/buildbot/changes

Modified Files:
	freshcvs.py pb.py 
Log Message:
Revision: arch at buildbot.sf.net--2004/buildbot--dev--0--patch-420
Creator:  Brian Warner <warner at monolith.lothar.com>

update compare_attrs so config-file reload works better

	* buildbot/changes/pb.py (PBChangeSource.compare_attrs): add this.
	Without it, a config-file reload fails to update an existing
	PBChangeSource.
	* buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): add
	username/passwd to compare_attrs, for the same reason
	* buildbot/status/html.py (Waterfall): add favicon to
	compare_attrs, same reason


Index: freshcvs.py
===================================================================
RCS file: /cvsroot/buildbot/buildbot/buildbot/changes/freshcvs.py,v
retrieving revision 1.20
retrieving revision 1.21
diff -u -d -r1.20 -r1.21
--- freshcvs.py	17 May 2005 10:14:09 -0000	1.20
+++ freshcvs.py	15 Nov 2005 08:38:05 -0000	1.21
@@ -65,7 +65,7 @@
         implements(IChangeSource)
     else:
         __implements__ = IChangeSource, TCPClient.__implements__
-    compare_attrs = ["where", "prefix"]
+    compare_attrs = ["where", "creds", "prefix"]
 
     changemaster = None # filled in when we're added
     connected = False
@@ -80,8 +80,8 @@
         l.source = self
         self.factory = f = FreshCVSConnectionFactory()
         f.source = self
-        creds = credentials.UsernamePassword(user, passwd)
-        f.startLogin(creds, client=l)
+        self.creds = credentials.UsernamePassword(user, passwd)
+        f.startLogin(self.creds, client=l)
         TCPClient.__init__(self, host, port, f)
 
     def __repr__(self):

Index: pb.py
===================================================================
RCS file: /cvsroot/buildbot/buildbot/buildbot/changes/pb.py,v
retrieving revision 1.9
retrieving revision 1.10
diff -u -d -r1.9 -r1.10
--- pb.py	25 Oct 2005 01:26:11 -0000	1.9
+++ pb.py	15 Nov 2005 08:38:05 -0000	1.10
@@ -48,6 +48,7 @@
             self.changemaster.addChange(change)
 
 class PBChangeSource(base.ChangeSource):
+    compare_attrs = ["user", "passwd", "port", "prefix", "sep"]
 
     def __init__(self, user="change", passwd="changepw", port=None,
                  prefix=None, sep="/"):