[Buildbot-commits] buildbot/buildbot/test test_status.py,1.27,1.28

[Brian Warner]

Update of /cvsroot/buildbot/buildbot/buildbot/test
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv25568/buildbot/test

Modified Files:
	test_status.py 
Log Message:
Revision: arch at buildbot.sf.net--2004/buildbot--dev--0--patch-412
Creator:  Brian Warner <warner at lothar.com>

fix silly typo, add TODO test

	* buildbot/process/factory.py (GNUAutoconf.__init__): fix a silly
	typo, caught by Mark Dillavou, closes SF#1216636.

	* buildbot/test/test_status.py (Log.TODO_testDuplicate): add notes
	about a test to add some day


Index: test_status.py
===================================================================
RCS file: /cvsroot/buildbot/buildbot/buildbot/test/test_status.py,v
retrieving revision 1.27
retrieving revision 1.28
diff -u -d -r1.27 -r1.28
--- test_status.py	26 Oct 2005 21:33:20 -0000	1.27
+++ test_status.py	5 Nov 2005 21:52:09 -0000	1.28
@@ -423,6 +423,21 @@
         os.unlink(l.getFilename())
         self.failIf(l.hasContents())
 
+    def TODO_testDuplicate(self):
+        # create multiple logs for the same step with the same logname, make
+        # sure their on-disk filenames are suitably uniquified. This
+        # functionality actually lives in BuildStepStatus and BuildStatus, so
+        # this test must involve more than just the MyLog class.
+
+        # naieve approach, doesn't work
+        l1 = MyLog(self.basedir, "duplicate")
+        l1.addStdout("Some text\n")
+        l1.finish()
+        l2 = MyLog(self.basedir, "duplicate")
+        l2.addStdout("Some more text\n")
+        l2.finish()
+        self.failIfEqual(l1.getFilename(), l2.getFilename())
+
     def testMerge1(self):
         l = MyLog(self.basedir, "merge1")
         l.addHeader("HEADER\n")