[Buildbot-commits] buildbot/buildbot interfaces.py,1.37,1.38

Brian Warner warner at users.sourceforge.net
Sat Nov 5 21:06:17 UTC 2005


Update of /cvsroot/buildbot/buildbot/buildbot
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv17285/buildbot

Modified Files:
	interfaces.py 
Log Message:
Revision: arch at buildbot.sf.net--2004/buildbot--dev--0--patch-408
Creator:  Brian Warner <warner at monolith.lothar.com>

add resubmit-build, change Step URLs

	* buildbot/interfaces.py (IBuilderControl.resubmitBuild): new
	method, takes an IBuildStatus and rebuilds it. It might make more
	sense to add this to IBuildControl instead, but that instance goes
	away completely once the build has finished, and resubmitting
	builds can take place weeks later.
	* buildbot/process/builder.py (BuilderControl.resubmitBuild): same
	* buildbot/status/html.py (StatusResourceBuild): also stash an
	IBuilderControl so we can use resubmitBuild.
	(StatusResourceBuild.body): render "resubmit" button if we can.
	Also add hrefs for each BuildStep
	(StatusResourceBuild.rebuild): add action for "resubmit" button
	(StatusResourceBuilder.getChild): give it an IBuilderControl

	* buildbot/status/builder.py (Status.getURLForThing): change the
	URL for BuildSteps to have a "step-" prefix, so the magic URLs
	that live as targets of buttons like "stop" and "rebuild" can't
	collide with them.
	* buildbot/status/builder.py (Status.getURLForThing): same
	* buildbot/status/html.py (StatusResourceBuild.getChild): same
	(StepBox.getBox): same
	* buildbot/test/test_web.py (GetURL): same
	(Logfile): same

	* buildbot/process/step.py (SVN.__init__): put svnurl/baseURL
	exclusivity checks after Source.__init__ upcall, so misspelled
	arguments will be reported more usefully
	(Darcs.__init__): same


Index: interfaces.py
===================================================================
RCS file: /cvsroot/buildbot/buildbot/buildbot/interfaces.py,v
retrieving revision 1.37
retrieving revision 1.38
diff -u -d -r1.37 -r1.38
--- interfaces.py	24 Oct 2005 21:39:52 -0000	1.37
+++ interfaces.py	5 Nov 2005 21:06:14 -0000	1.38
@@ -833,6 +833,12 @@
         that a slave will eventually connect. This method is appropriate for
         use by things like the web-page 'Force Build' button."""
 
+    def resubmitBuild(buildStatus, reason="<rebuild, no reason given>"):
+        """Rebuild something we've already built before. This submits a
+        BuildRequest to our Builder using the same SourceStamp as the earlier
+        build. This has no effect (but may eventually raise an exception) if
+        this Build has not yet finished."""
+
     def getPendingBuilds():
         """Return a list of L{IBuildRequestControl} objects for this Builder.
         Each one corresponds to a pending build that has not yet started (due





More information about the Commits mailing list