[Buildbot-commits] buildbot ChangeLog,1.458,1.459

[Brian Warner]

Update of /cvsroot/buildbot/buildbot
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv4686

Modified Files:
	ChangeLog 
Log Message:
Revision: arch at buildbot.sf.net--2004/buildbot--dev--0--patch-225
Creator:  Brian Warner <warner at monolith.lothar.com>

fix slave-reconnect on network loss

	* buildbot/pbutil.py (ReconnectingPBClientFactory): Twisted-1.3
	erroneously abandons the connection (in clientConnectionFailed)
	for non-UserErrors, which means that if we lose the connection due
	to a network problem or a timeout, we'll never try to reconnect.
	Fix this by not upcalling to the buggy parent method. Note:
	twisted-2.0 fixes this, but the function only has 3 lines so it
	makes more sense to copy it than to try and detect the buggyness
	of the parent class.


Index: ChangeLog
===================================================================
RCS file: /cvsroot/buildbot/buildbot/ChangeLog,v
retrieving revision 1.458
retrieving revision 1.459
diff -u -d -r1.458 -r1.459
--- ChangeLog	24 May 2005 18:57:50 -0000	1.458
+++ ChangeLog	24 May 2005 22:33:00 -0000	1.459
@@ -1,5 +1,14 @@
 2005-05-24  Brian Warner  <warner at lothar.com>
 
+	* buildbot/pbutil.py (ReconnectingPBClientFactory): Twisted-1.3
+	erroneously abandons the connection (in clientConnectionFailed)
+	for non-UserErrors, which means that if we lose the connection due
+	to a network problem or a timeout, we'll never try to reconnect.
+	Fix this by not upcalling to the buggy parent method. Note:
+	twisted-2.0 fixes this, but the function only has 3 lines so it
+	makes more sense to copy it than to try and detect the buggyness
+	of the parent class.
+
 	* buildbot/changes/changes.py (Change.branch): doh! Add a
 	class-level attribute to accomodate old Change instances that were
 	pickled before 0.6.5 (where .branch was added for new Changes).