[Buildbot-commits] buildbot ChangeLog,1.444,1.445

[Brian Warner]

Update of /cvsroot/buildbot/buildbot
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv6131

Modified Files:
	ChangeLog 
Log Message:
Revision: arch at buildbot.sf.net--2004/buildbot--dev--0--patch-195
Creator:  Brian Warner <warner at monolith.lothar.com>

don't explode when trying to interrupt non-existent Command

	* buildbot/slave/commands.py (ShellCommand.kill): if somehow this
	gets called when there isn't actually an active process, just end
	the Command instead of blowing up. I don't know how it gets into
	this state, but the twisted win32 buildslave will sometimes hang,
	and when it shakes its head and comes back, it thinks it's still
	running a Command. The next build causes this command to be
	interrupted, but the lack of self.process.pid breaks the interrupt
	attempt.


Index: ChangeLog
===================================================================
RCS file: /cvsroot/buildbot/buildbot/ChangeLog,v
retrieving revision 1.444
retrieving revision 1.445
diff -u -d -r1.444 -r1.445
--- ChangeLog	17 May 2005 20:31:19 -0000	1.444
+++ ChangeLog	17 May 2005 22:19:18 -0000	1.445
@@ -1,5 +1,14 @@
 2005-05-17  Brian Warner  <warner at lothar.com>
 
+	* buildbot/slave/commands.py (ShellCommand.kill): if somehow this
+	gets called when there isn't actually an active process, just end
+	the Command instead of blowing up. I don't know how it gets into
+	this state, but the twisted win32 buildslave will sometimes hang,
+	and when it shakes its head and comes back, it thinks it's still
+	running a Command. The next build causes this command to be
+	interrupted, but the lack of self.process.pid breaks the interrupt
+	attempt.
+
 	* NEWS: document changes since the last release
 
 	* buildbot/scripts/runner.py (start): change 'buildbot start' to