[Buildbot-commits] buildbot/buildbot/slave commands.py,1.33,1.34

[Brian Warner]

Update of /cvsroot/buildbot/buildbot/buildbot/slave
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv9810/buildbot/slave

Modified Files:
	commands.py 
Log Message:
Revision: arch at buildbot.sf.net--2004/buildbot--dev--0--patch-187
Creator:  Brian Warner <warner at monolith.lothar.com>

fix deprecation warnings in test suite

	* everything: fixed all deprecation warnings when running against
	Twisted-2.0 . (at least all the ones in buildbot code, there are a
	few that come from Twisted itself). This involved putting most of
	the Twisted-version specific code in the new buildbot.twcompat
	module, and creating some abstract base classes in
	buildbot.changes.base and buildbot.status.base (which might be
	useful anyway). __implements__ is a nuisance and requires an ugly
	'if' clause everywhere.

	* buildbot/test/test_status.py (Mail.testMail): add a 0.1 second
	delay before finishing the test: it seems that smtp.sendmail
	doesn't hang up on the server, so we must wait a moment so it can
	hang up on us. This removes the trial warning about an unclean
	reactor.


Index: commands.py
===================================================================
RCS file: /cvsroot/buildbot/buildbot/buildbot/slave/commands.py,v
retrieving revision 1.33
retrieving revision 1.34
diff -u -d -r1.33 -r1.34
--- commands.py	17 May 2005 04:40:59 -0000	1.33
+++ commands.py	17 May 2005 10:14:11 -0000	1.34
@@ -6,6 +6,7 @@
 from twisted.internet import reactor, defer
 from twisted.python import log, failure, runtime
 
+from buildbot.twcompat import implements
 from buildbot.slave.interfaces import ISlaveCommand
 from buildbot.slave.registry import registerSlaveCommand
 
@@ -309,7 +310,10 @@
 
 
 class Command:
-    __implements__ = ISlaveCommand,
+    if implements:
+        implements(ISlaveCommand)
+    else:
+        __implements__ = ISlaveCommand
 
     """This class defines one command that can be invoked by the build master.
     The command is executed on the slave side, and always sends back a