[Buildbot-commits] buildbot/buildbot interfaces.py,1.24,1.25

Brian Warner warner at users.sourceforge.net
Thu May 12 21:55:59 UTC 2005


Update of /cvsroot/buildbot/buildbot/buildbot
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv15619/buildbot

Modified Files:
	interfaces.py 
Log Message:
Revision: arch at buildbot.sf.net--2004/buildbot--dev--0--patch-165
Creator:  Brian Warner <warner at monolith.lothar.com>

fix OfflineLogFile to work with html.Waterfall

	* buildbot/status/builder.py (OfflineLogFile.getChunks): have this
	method generate chunks instead of returning a big list. This
	allows the same method to be used for both old LogFile and new
	OfflineLogFile.
	(OfflineLogFile.getText): use the generator
	(OfflineLogFile.subscribe): same
	* buildbot/status/html.py (TextLog.resumeProducing): same
	* buildbot/interfaces.py (IStatusLog.getChunks): document it


Index: interfaces.py
===================================================================
RCS file: /cvsroot/buildbot/buildbot/buildbot/interfaces.py,v
retrieving revision 1.24
retrieving revision 1.25
diff -u -d -r1.24 -r1.25
--- interfaces.py	24 Apr 2005 21:30:23 -0000	1.24
+++ interfaces.py	12 May 2005 21:55:57 -0000	1.25
@@ -493,8 +493,8 @@
         all chunks (including headers) together."""
 
     def getChunks():
-        """Return a list of (channel, text) tuples. 'channel' is a number, 0
-        for stdout, 1 for stderr, 2 for header. (note that stderr is merged
+        """Generate a list of (channel, text) tuples. 'channel' is a number,
+        0 for stdout, 1 for stderr, 2 for header. (note that stderr is merged
         into stdout if PTYs are in use)."""
 
 





More information about the Commits mailing list