[Buildbot-commits] buildbot ChangeLog,1.417,1.418

[Brian Warner]

Update of /cvsroot/buildbot/buildbot
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv25130

Modified Files:
	ChangeLog 
Log Message:
Revision: arch at buildbot.sf.net--2004/buildbot--dev--0--patch-141
Creator:  Brian Warner <warner at monolith.lothar.com>

Merged from warner at monolith.lothar.com--2005 (patch 6)

Patches applied:

 * warner at monolith.lothar.com--2005/buildbot--dev--0--patch-6
   don't spawn twistd or /bin/kill in 'buildbot start/stop'


Index: ChangeLog
===================================================================
RCS file: /cvsroot/buildbot/buildbot/ChangeLog,v
retrieving revision 1.417
retrieving revision 1.418
diff -u -d -r1.417 -r1.418
--- ChangeLog	6 May 2005 04:57:58 -0000	1.417
+++ ChangeLog	6 May 2005 05:01:11 -0000	1.418
@@ -1,5 +1,15 @@
 2005-05-05  Brian Warner  <warner at lothar.com>
 
+	* buildbot/scripts/runner.py (start): if there is no Makefile,
+	launch the app by importing twistd's internals and calling run(),
+	rather than spawning a new twistd process. This stands a much
+	better chance of working under windows.
+	(stop): kill the process with os.kill instead of spawning
+	/bin/kill, again to reduce the number of external programs which
+	windows might not have in the PATH. Also wait up to 5 seconds for
+	the process to go away, allowing things like 'buildbot stop;
+	buildbot start' to be reliable in the face of slow shutdowns.
+
 	* buildbot/master.py (Dispatcher.__getstate__): remove old
 	.tap-related methods
 	(BuildMaster.__getstate__): same