[Buildbot-commits] buildbot/buildbot/scripts runner.py,1.16,1.17

Brian Warner warner at users.sourceforge.net
Wed May 4 04:14:33 UTC 2005


Update of /cvsroot/buildbot/buildbot/buildbot/scripts
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv24073/buildbot/scripts

Modified Files:
	runner.py 
Log Message:
Revision: arch at buildbot.sf.net--2004/buildbot--dev--0--patch-123
Creator:  Brian Warner <warner at monolith.lothar.com>

make 'buildbot sendchange' actually work

	* buildbot/scripts/runner.py (sendchange): oops, fix the command
	so 'buildbot sendchange' actually works. The earlier test only
	covered the internal (non-reactor-running) form.


Index: runner.py
===================================================================
RCS file: /cvsroot/buildbot/buildbot/buildbot/scripts/runner.py,v
retrieving revision 1.16
retrieving revision 1.17
diff -u -d -r1.16 -r1.17
--- runner.py	4 May 2005 02:09:37 -0000	1.16
+++ runner.py	4 May 2005 04:14:31 -0000	1.17
@@ -340,7 +340,7 @@
         self['files'] = args
 
 
-def sendchange(config):
+def sendchange(config, runReactor=False):
     from buildbot.clients.sendchange import Sender
 
     opts = loadOptions()
@@ -368,14 +368,12 @@
 
     s = Sender(master, user)
     d = s.send(revision, comments, files)
+    if runReactor:
+        d.addCallbacks(s.printSuccess, s.printFailure)
+        d.addCallback(s.stop)
+        s.run()
     return d
 
-def do_sendchange(config):
-    d = sendchange(config)
-    d.addCallbacks(s.printSuccess, s.printFailure)
-    d.addCallback(s.stop)
-    s.run()
-
 
 class Options(usage.Options):
     synopsis = "Usage:    buildbot <command> [command options]"
@@ -435,7 +433,7 @@
     elif command == "sighup":
         stop(so, "-HUP")
     elif command == "sendchange":
-        do_sendchange(so)
+        do_sendchange(so, True)
     elif command == "debugclient":
         debugclient(so)
     elif command == "statuslog":





More information about the Commits mailing list