[Buildbot-commits] buildbot/buildbot/status builder.py,1.61,1.62

[Brian Warner]

Update of /cvsroot/buildbot/buildbot/buildbot/status
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv24661/buildbot/status

Modified Files:
	builder.py 
Log Message:
Revision: arch at buildbot.sf.net--2004/buildbot--dev--0--patch-266
Creator:  Brian Warner <warner at monolith.lothar.com>

deliver large addCompleteLog() files correctly

Twisted's NetstringReceiver imposes a cap of 100k on the chunks of a
LogFile, which causes problems when addCompleteLog() is used to create
large LogFiles.

	* buildbot/process/step.py (BuildStep.addCompleteLog): break the
	logfile up into chunks, both to avoid NetstringReceiver.MAX_LENGTH
	and to improve memory usage when streaming the file out to a web
	browser.
	* buildbot/status/builder.py (LogFile.addEntry): change > to >= to
	make this work cleanly

--This line, and those below, will be ignored--
Files to commit:
   <can't compute list>

This list might be incomplete or outdated if editing the log
message was not invoked from an up-to-date changes buffer!


Index: builder.py
===================================================================
RCS file: /cvsroot/buildbot/buildbot/buildbot/status/builder.py,v
retrieving revision 1.61
retrieving revision 1.62
diff -u -d -r1.61 -r1.62
--- builder.py	19 Jul 2005 23:12:01 -0000	1.61
+++ builder.py	8 Aug 2005 21:39:46 -0000	1.62
@@ -363,7 +363,7 @@
             self.merge()
         self.runEntries.append((channel, text))
         self.runLength += len(text)
-        if self.runLength > self.chunkSize:
+        if self.runLength >= self.chunkSize:
             self.merge()
 
         for w in self.watchers: