[Buildbot-commits] buildbot ChangeLog,1.479,1.480

Brian Warner warner at users.sourceforge.net
Tue Aug 9 00:43:37 UTC 2005


Update of /cvsroot/buildbot/buildbot
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv26164

Modified Files:
	ChangeLog 
Log Message:
Revision: arch at buildbot.sf.net--2004/buildbot--dev--0--patch-268
Creator:  Brian Warner <warner at monolith.lothar.com>

fix the large-logfile-hang against twisted-1.3.0

	* buildbot/status/builder.py (LogFileProducer.resumeProducing):
	put off the actual resumeProducing for a moment with
	reactor.callLater(0). This works around a twisted-1.3.0 bug which
	causes large logfiles to hang midway through.

	* buildbot/test/test_status.py (Log.testMerge3): update to match new
	addEntry merging (>=chunkSize) behavior
	(Log.testConsumer): update to handle new callLater(0) behavior

	* buildbot/test/test_web.py: rearrange tests a bit, add test for
	both the MAX_LENGTH bugfix and the resumeProducing hang.

--This line, and those below, will be ignored--
Files to commit:
   <can't compute list>

This list might be incomplete or outdated if editing the log
message was not invoked from an up-to-date changes buffer!


Index: ChangeLog
===================================================================
RCS file: /cvsroot/buildbot/buildbot/ChangeLog,v
retrieving revision 1.479
retrieving revision 1.480
diff -u -d -r1.479 -r1.480
--- ChangeLog	8 Aug 2005 21:39:46 -0000	1.479
+++ ChangeLog	9 Aug 2005 00:43:34 -0000	1.480
@@ -1,5 +1,17 @@
 2005-08-08  Brian Warner  <warner at lothar.com>
 
+	* buildbot/test/test_status.py (Log.testMerge3): update to match new
+	addEntry merging (>=chunkSize) behavior
+	(Log.testConsumer): update to handle new callLater(0) behavior
+
+	* buildbot/test/test_web.py: rearrange tests a bit, add test for
+	both the MAX_LENGTH bugfix and the resumeProducing hang.
+
+	* buildbot/status/builder.py (LogFileProducer.resumeProducing):
+	put off the actual resumeProducing for a moment with
+	reactor.callLater(0). This works around a twisted-1.3.0 bug which
+	causes large logfiles to hang midway through.
+
 	* buildbot/process/step.py (BuildStep.addCompleteLog): break the
 	logfile up into chunks, both to avoid NetstringReceiver.MAX_LENGTH
 	and to improve memory usage when streaming the file out to a web





More information about the Commits mailing list