[Buildbot-commits] buildbot ChangeLog,1.393,1.394

[Brian Warner]

Update of /cvsroot/buildbot/buildbot
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv28679

Modified Files:
	ChangeLog 
Log Message:
(ShellCommand._startCommand): prepend 'cmd.exe' (or rather
os.environ['COMSPEC']) to the argv list when running under windows. This
appears to be the best way to allow BuildSteps to do something normal like
'trial -v buildbot.test' or 'make foo' and still expect it to work. The idea
is to make the BuildSteps look as much like what a developer would type when
compiling or testing the tree by hand. This approach probably has problems
when there are spaces in the arguments, so if you've got windows buildslaves,
you'll need to pay close attention to your commands.


Index: ChangeLog
===================================================================
RCS file: /cvsroot/buildbot/buildbot/ChangeLog,v
retrieving revision 1.393
retrieving revision 1.394
diff -u -d -r1.393 -r1.394
--- ChangeLog	26 Apr 2005 20:25:31 -0000	1.393
+++ ChangeLog	26 Apr 2005 21:37:17 -0000	1.394
@@ -1,5 +1,16 @@
 2005-04-26  Brian Warner  <warner at lothar.com>
 
+	* buildbot/slave/commands.py (ShellCommand._startCommand): prepend
+	'cmd.exe' (or rather os.environ['COMSPEC']) to the argv list when
+	running under windows. This appears to be the best way to allow
+	BuildSteps to do something normal like 'trial -v buildbot.test' or
+	'make foo' and still expect it to work. The idea is to make the
+	BuildSteps look as much like what a developer would type when
+	compiling or testing the tree by hand. This approach probably has
+	problems when there are spaces in the arguments, so if you've got
+	windows buildslaves, you'll need to pay close attention to your
+	commands.
+
 	* buildbot/status/html.py (WaterfallStatusResource.body): add the
 	timezone to the timestamp column.
 	* buildbot/test/test_web.py (WebTest.test_waterfall): test it