[Buildbot-commits] buildbot ChangeLog,1.370,1.371

[Brian Warner]

Update of /cvsroot/buildbot/buildbot
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv24338

Modified Files:
	ChangeLog 
Log Message:
Revision: arch at buildbot.sf.net--2004/buildbot--dev--0--patch-73
Creator:  Brian Warner <warner at monolith.lothar.com>

clean up ChangeSource handling

2005-04-23  Brian Warner  <warner at lothar.com>

   * buildbot/changes/changes.py: import defer, oops
   (ChangeMaster): remove the .sources list, rely upon the fact that
   MultiServices can be treated as sequences of their children. This
   cleans up the add/remove ChangeSource routines a lot, as we keep
   exactly one list of the current sources instead of three.

   * buildbot/master.py (BuildMaster.__init__): remove .sources, set
   up an empty ChangeMaster at init time.
   (BuildMaster.loadChanges): if there are changes to be had from
   disk, replace self.change_svc with the new ones. If not, keep
   using the empty ChangeMaster set up in __init__.
   (BuildMaster.loadConfig_Sources): use list(self.change_svc)
   instead of a separate list, makes the code a bit cleaner.
   * buildbot/test/test_config.py (ConfigTest.testSimple): match it
   (ConfigTest.testSources): same, also wait for loadConfig to finish.
   Extend the test to make sure we can get rid of the sources when
   we're done.


Index: ChangeLog
===================================================================
RCS file: /cvsroot/buildbot/buildbot/ChangeLog,v
retrieving revision 1.370
retrieving revision 1.371
diff -u -d -r1.370 -r1.371
--- ChangeLog	23 Apr 2005 00:01:22 -0000	1.370
+++ ChangeLog	23 Apr 2005 10:22:11 -0000	1.371
@@ -1,3 +1,23 @@
+2005-04-23  Brian Warner  <warner at lothar.com>
+
+	* buildbot/changes/changes.py: import defer, oops
+	(ChangeMaster): remove the .sources list, rely upon the fact that
+	MultiServices can be treated as sequences of their children. This
+	cleans up the add/remove ChangeSource routines a lot, as we keep
+	exactly one list of the current sources instead of three.
+
+	* buildbot/master.py (BuildMaster.__init__): remove .sources, set
+	up an empty ChangeMaster at init time.
+	(BuildMaster.loadChanges): if there are changes to be had from
+	disk, replace self.change_svc with the new ones. If not, keep
+	using the empty ChangeMaster set up in __init__.
+	(BuildMaster.loadConfig_Sources): use list(self.change_svc)
+	instead of a separate list, makes the code a bit cleaner.
+	* buildbot/test/test_config.py (ConfigTest.testSimple): match it
+	(ConfigTest.testSources): same, also wait for loadConfig to finish.
+	Extend the test to make sure we can get rid of the sources when
+	we're done.
+
 2005-04-22  Brian Warner  <warner at lothar.com>
 
 	* buildbot/scripts/runner.py (Maker.mkinfo): create the info/admin