[Buildbot-commits] buildbot ChangeLog,1.368,1.369 .arch-inventory,1.1,1.2

[Brian Warner]

Update of /cvsroot/buildbot/buildbot
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv15396

Modified Files:
	ChangeLog .arch-inventory 
Log Message:
Revision: arch at buildbot.sf.net--2004/buildbot--dev--0--patch-69
Creator:  Brian Warner <warner at monolith.lothar.com>

fix propagation of changes to .builddir

2005-04-22  Brian Warner  <warner at lothar.com>

   * buildbot/test/test_run.py (RunMixin.shutdownSlave): remove the
   whendone= argument, just return the Deferred and let the caller do
   what they want with it.
   (Disconnect.testBuild1): wait for shutdownSlave
   (Basedir.testChangeBuilddir): new test to make sure changes to the
   builddir actually get propagated to the slave

   * buildbot/slave/bot.py (SlaveBuilder.setBuilddir): use an
   explicit method, rather than passing the builddir in __init__ .
   Make sure to update self.basedir too, this was broken before.
   (Bot.remote_setBuilderList): use b.setBuilddir for both new
   builders and for ones that have just had their builddir changed.
   (BotFactory): add a class-level .perspective attribute, so
   BuildSlave.waitUntilDisconnected won't get upset when the
   connection hasn't yet been established
   (BuildSlave.__init__): keep track of the bot.Bot instance, so
   tests can reach through it to inspect the SlaveBuilders

   * buildbot/process/base.py (Build.buildException): explain the
   log.err with a log.msg
   * buildbot/process/builder.py (Builder.startBuild): same
   (Builder._startBuildFailed): improve error message

   * buildbot/pbutil.py (RBCP.failedToGetPerspective): if the failure
   occurred because we lost the brand-new connection, retry instead
   of giving up. If not, it's probably an authorization failure, and
   it makes sense to stop trying. Make sure we log.msg the reason
   that we're log.err'ing the failure, otherwise test failures are
   really hard to figure out.

   * buildbot/master.py: change loadConfig() to return a Deferred
   that doesn't fire until the change has been fully implemented.
   This means any connected slaves have been updated with the new
   builddir. This change makes it easier to test the code which
   actually implements this builddir-updating.
   (BotPerspective.addBuilder): return Deferred
   (BotPerspective.removeBuilder): same
   (BotPerspective.attached): same
   (BotPerspective._attached): same. finish with remote_print before
   starting the getSlaveInfo, instead of doing them in parallel
   (BotPerspective.list_done): same
   (BotMaster.removeSlave): same. Fix the typo that meant we weren't
   actually calling slave.disconnect()
   (BotMaster.addBuilder): same
   (BotMaster.removeBuilder): same
   (BuildMaster.loadConfig): same
   (BuildMaster.loadConfig_Slaves): same
   (BuildMaster.loadConfig_Sources): same
   (BuildMaster.loadConfig_Builders): same
   (BuildMaster.loadConfig_status): same

   * buildbot/changes/changes.py (ChangeMaster.removeSource): return
   a Deferred that fires when the source is finally removed


Index: .arch-inventory
===================================================================
RCS file: /cvsroot/buildbot/buildbot/.arch-inventory,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -d -r1.1 -r1.2
--- .arch-inventory	11 Apr 2005 19:30:30 -0000	1.1
+++ .arch-inventory	22 Apr 2005 21:29:20 -0000	1.2
@@ -1,3 +1,4 @@
 precious ^m$
 precious ^s$
 precious ^svn$
+junk ^_trial_temp$

Index: ChangeLog
===================================================================
RCS file: /cvsroot/buildbot/buildbot/ChangeLog,v
retrieving revision 1.368
retrieving revision 1.369
diff -u -d -r1.368 -r1.369
--- ChangeLog	22 Apr 2005 18:41:01 -0000	1.368
+++ ChangeLog	22 Apr 2005 21:29:20 -0000	1.369
@@ -1,5 +1,59 @@
 2005-04-22  Brian Warner  <warner at lothar.com>
 
+	* buildbot/test/test_run.py (RunMixin.shutdownSlave): remove the
+	whendone= argument, just return the Deferred and let the caller do
+	what they want with it.
+	(Disconnect.testBuild1): wait for shutdownSlave
+	(Basedir.testChangeBuilddir): new test to make sure changes to the
+	builddir actually get propagated to the slave
+
+	* buildbot/slave/bot.py (SlaveBuilder.setBuilddir): use an
+	explicit method, rather than passing the builddir in __init__ .
+	Make sure to update self.basedir too, this was broken before.
+	(Bot.remote_setBuilderList): use b.setBuilddir for both new
+	builders and for ones that have just had their builddir changed.
+	(BotFactory): add a class-level .perspective attribute, so
+	BuildSlave.waitUntilDisconnected won't get upset when the
+	connection hasn't yet been established
+	(BuildSlave.__init__): keep track of the bot.Bot instance, so
+	tests can reach through it to inspect the SlaveBuilders
+
+	* buildbot/process/base.py (Build.buildException): explain the
+	log.err with a log.msg
+	* buildbot/process/builder.py (Builder.startBuild): same
+	(Builder._startBuildFailed): improve error message
+
+	* buildbot/pbutil.py (RBCP.failedToGetPerspective): if the failure
+	occurred because we lost the brand-new connection, retry instead
+	of giving up. If not, it's probably an authorization failure, and
+	it makes sense to stop trying. Make sure we log.msg the reason
+	that we're log.err'ing the failure, otherwise test failures are
+	really hard to figure out.
+
+	* buildbot/master.py: change loadConfig() to return a Deferred
+	that doesn't fire until the change has been fully implemented.
+	This means any connected slaves have been updated with the new
+	builddir. This change makes it easier to test the code which
+	actually implements this builddir-updating.
+	(BotPerspective.addBuilder): return Deferred
+	(BotPerspective.removeBuilder): same
+	(BotPerspective.attached): same
+	(BotPerspective._attached): same. finish with remote_print before
+	starting the getSlaveInfo, instead of doing them in parallel
+	(BotPerspective.list_done): same
+	(BotMaster.removeSlave): same. Fix the typo that meant we weren't
+	actually calling slave.disconnect()
+	(BotMaster.addBuilder): same
+	(BotMaster.removeBuilder): same
+	(BuildMaster.loadConfig): same
+	(BuildMaster.loadConfig_Slaves): same
+	(BuildMaster.loadConfig_Sources): same
+	(BuildMaster.loadConfig_Builders): same
+	(BuildMaster.loadConfig_status): same
+
+	* buildbot/changes/changes.py (ChangeMaster.removeSource): return
+	a Deferred that fires when the source is finally removed
+
 	* buildbot/slave/commands.py (SourceBase.doClobber): when removing
 	the previous tree on win32, where we have to do it synchronously,
 	make sure we return a Deferred anyway.