[Buildbot-commits] buildbot ChangeLog,1.349,1.350

Brian Warner warner at users.sourceforge.net
Sun Apr 17 10:50:03 UTC 2005


Update of /cvsroot/buildbot/buildbot
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv1926

Modified Files:
	ChangeLog 
Log Message:
Revision: arch at buildbot.sf.net--2004/buildbot--dev--0--patch-38
Creator:  Brian Warner <warner at monolith.lothar.com>

fix memory leak involving buildbot.status.html.TextLog


Index: ChangeLog
===================================================================
RCS file: /cvsroot/buildbot/buildbot/ChangeLog,v
retrieving revision 1.349
retrieving revision 1.350
diff -u -d -r1.349 -r1.350
--- ChangeLog	12 Apr 2005 00:28:45 -0000	1.349
+++ ChangeLog	17 Apr 2005 10:50:01 -0000	1.350
@@ -1,3 +1,11 @@
+2005-04-17  Brian Warner  <warner at lothar.com>
+
+	* buildbot/status/html.py (TextLog.finished): null out self.req
+	when we're done, otherwise the reference cycle of TextLog to .req
+	to .notifications to a Deferred to TextLog.stop keeps them from
+	being collected, and consumes a huge (610MB on pyramid at last
+	check) amount of memory.
+
 2005-04-11  Brian Warner  <warner at lothar.com>
 
 	* buildbot/test/test_vc.py (VCSupport.__init__): use abspath() to





More information about the Commits mailing list