[Buildbot-commits] buildbot/buildbot/status html.py,1.43,1.44

[Brian Warner]

Update of /cvsroot/buildbot/buildbot/buildbot/status
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv16067

Modified Files:
	html.py 
Log Message:
add TODO about using a producer to send the logfile less stupidly


Index: html.py
===================================================================
RCS file: /cvsroot/buildbot/buildbot/buildbot/status/html.py,v
retrieving revision 1.43
retrieving revision 1.44
diff -u -d -r1.43 -r1.44
--- html.py	19 Oct 2004 18:31:49 -0000	1.43
+++ html.py	23 Nov 2004 03:58:15 -0000	1.44
@@ -509,6 +509,16 @@
             data += self.htmlHeader(request)
         data += self.content(self.original.getChunks(), asText)
 
+        # TODO: to implement a producer for this:
+        #  Create an object that knows about the LogFile. That object's
+        #  .resumeProducing method should pull text from the LogFile's
+        #  .entries, convert them to HTML, then send them to request.write .
+        #  (remember that .entries may be added while the request is being
+        #  served). When all .entries are consumed, send everything in
+        #  .runEntries (oh and do those all before they get merged into a
+        #  new .entries item). Then attach the request to our .watchers
+        #  method and make sure the LogFile knows about us.
+
         if self.original.finished:
             if not asText:
                 data += self.htmlFooter()