[Buildbot-commits] buildbot ChangeLog,1.336,1.337

Brian Warner warner at users.sourceforge.net
Sat Dec 11 11:12:45 UTC 2004


Update of /cvsroot/buildbot/buildbot
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv3363

Modified Files:
	ChangeLog 
Log Message:
* buildbot/slave/bot.py (BotFactory): revamp keepalive/lost-master detection
code. Require some sign of life from the buildmaster every
BotFactory.keepaliveInterval seconds. Provoke this indication at
BotFactory.keepaliveTimeout seconds before the deadline by sending a
keepalive request. We don't actually care if that request is answered in a
timely fashion, what we care about is that .activity() is called before the
deadline. .activity() is triggered by any PB message from the master
(including an ack to one of the slave's status-update messages). With this
new scheme, large status messages over slow pipes are OK, as long as any
given message can be sent (and thus acked) within .keepaliveTimeout seconds
(which defaults to 30).
(SlaveBuilder.remote_startCommand): record activity
(SlaveBuilder.ackUpdate): same
(SlaveBuilder.ackComplete): same
(BotFactory.gotPerspective): same
* buildbot/test/test_run.py (Disconnect.testSlaveTimeout): test it


Index: ChangeLog
===================================================================
RCS file: /cvsroot/buildbot/buildbot/ChangeLog,v
retrieving revision 1.336
retrieving revision 1.337
diff -u -d -r1.336 -r1.337
--- ChangeLog	9 Dec 2004 10:26:14 -0000	1.336
+++ ChangeLog	11 Dec 2004 11:12:35 -0000	1.337
@@ -1,3 +1,23 @@
+2004-12-11  Brian Warner  <warner at lothar.com>
+
+	* buildbot/slave/bot.py (BotFactory): revamp keepalive/lost-master
+	detection code. Require some sign of life from the buildmaster
+	every BotFactory.keepaliveInterval seconds. Provoke this
+	indication at BotFactory.keepaliveTimeout seconds before the
+	deadline by sending a keepalive request. We don't actually care if
+	that request is answered in a timely fashion, what we care about
+	is that .activity() is called before the deadline. .activity() is
+	triggered by any PB message from the master (including an ack to
+	one of the slave's status-update messages). With this new scheme,
+	large status messages over slow pipes are OK, as long as any given
+	message can be sent (and thus acked) within .keepaliveTimeout
+	seconds (which defaults to 30).
+	(SlaveBuilder.remote_startCommand): record activity
+	(SlaveBuilder.ackUpdate): same
+	(SlaveBuilder.ackComplete): same
+	(BotFactory.gotPerspective): same
+	* buildbot/test/test_run.py (Disconnect.testSlaveTimeout): test it
+
 2004-12-09  Brian Warner  <warner at lothar.com>
 
 	* buildbot/status/html.py (StatusResourceBuilder.getChild): remove





More information about the Commits mailing list