[Buildbot] #3637: Crashing on wrong configuration

[Buildbot trac]

#3637: Crashing on wrong configuration
----------------------+-----------------------
Reporter:  kayhayen   |      Owner:
    Type:  undecided  |     Status:  new
Priority:  major      |  Milestone:  undecided
 Version:  0.9.0      |   Keywords:
----------------------+-----------------------
 My nine buildbot ran fine until I made a change:


 {{{
 c["schedulers"].append(
     ForceScheduler(
          name         = "force-coverage-update",
          builderNames = coverage_cases
     )
 )

 c["builders"].append(
     ForceScheduler(
          name         = "force-coverage-update",
          builderNames = ["rel-stable-pypi"]
     )
 )

 Notice the duplicate scheduler name. I added the later, via copy and
 paste, and failed to update the name. Instead of giving an error, Buildbot
 crashed at startup:

 }}}

 This led to

 {{{

           File "/home/nuitka-buildmaster/sandbox/local/lib/python2.7/site-
 packages/twisted/internet/defer.p
 y", line 1241, in gotResult
             _inlineCallbacks(r, g, deferred)
           File "/home/nuitka-buildmaster/sandbox/local/lib/python2.7/site-
 packages/twisted/internet/defer.p
 y", line 1183, in _inlineCallbacks
             result = result.throwExceptionIntoGenerator(g)
           File "/home/nuitka-buildmaster/sandbox/local/lib/python2.7/site-
 packages/twisted/python/failure.py", line 389, in
 throwExceptionIntoGenerator
             return g.throw(self.type, self.value, self.tb)
         --- <exception caught here> ---
           File "/home/nuitka-buildmaster/sandbox/local/lib/python2.7/site-
 packages/buildbot/master.py", line 243, in startService
             self.config_loader.loadConfig)
           File "/home/nuitka-buildmaster/sandbox/local/lib/python2.7/site-
 packages/twisted/python/threadpool.py", line 246, in inContext
             result = inContext.theWork()
           File "/home/nuitka-buildmaster/sandbox/local/lib/python2.7/site-
 packages/twisted/python/threadpool.py", line 262, in <lambda>
             inContext.theWork = lambda: context.call(ctx, func, *args,
 **kw)
           File "/home/nuitka-buildmaster/sandbox/local/lib/python2.7/site-
 packages/twisted/python/context.py", line 118, in callWithContext
             return self.currentContext().callWithContext(ctx, func, *args,
 **kw)
           File "/home/nuitka-buildmaster/sandbox/local/lib/python2.7/site-
 packages/twisted/python/context.py", line 81, in callWithContext
             return func(*args,**kw)
           File "/home/nuitka-buildmaster/sandbox/local/lib/python2.7/site-
 packages/buildbot/config.py", line 162, in loadConfig
             config = MasterConfig.loadFromDict(config_dict, filename)
           File "/home/nuitka-buildmaster/sandbox/local/lib/python2.7/site-
 packages/buildbot/config.py", line 339, in loadFromDict
             config.check_single_master()
           File "/home/nuitka-buildmaster/sandbox/local/lib/python2.7/site-
 packages/buildbot/config.py", line 816, in check_single_master
             unscheduled_buildernames = set([b.name for b in
 self.builders])
         exceptions.AttributeError: 'NoneType' object has no attribute
 'name'
           File "/home/nuitka-buildmaster/sandbox/local/lib/python2.7/site-
 packages/twisted/internet/defer.p
 y", line 1241, in gotResult
             _inlineCallbacks(r, g, deferred)
           File "/home/nuitka-buildmaster/sandbox/local/lib/python2.7/site-
 packages/twisted/internet/defer.p
 y", line 1183, in _inlineCallbacks
             result = result.throwExceptionIntoGenerator(g)
           File "/home/nuitka-buildmaster/sandbox/local/lib/python2.7/site-
 packages/twisted/python/failure.py", line 389, in
 throwExceptionIntoGenerator
             return g.throw(self.type, self.value, self.tb)
         --- <exception caught here> ---
           File "/home/nuitka-buildmaster/sandbox/local/lib/python2.7/site-
 packages/buildbot/master.py", line 243, in startService
             self.config_loader.loadConfig)
           File "/home/nuitka-buildmaster/sandbox/local/lib/python2.7/site-
 packages/twisted/python/threadpool.py", line 246, in inContext
             result = inContext.theWork()
           File "/home/nuitka-buildmaster/sandbox/local/lib/python2.7/site-
 packages/twisted/python/threadpool.py", line 262, in <lambda>
             inContext.theWork = lambda: context.call(ctx, func, *args,
 **kw)
           File "/home/nuitka-buildmaster/sandbox/local/lib/python2.7/site-
 packages/twisted/python/context.py", line 118, in callWithContext
             return self.currentContext().callWithContext(ctx, func, *args,
 **kw)
           File "/home/nuitka-buildmaster/sandbox/local/lib/python2.7/site-
 packages/twisted/python/context.py", line 81, in callWithContext
             return func(*args,**kw)
           File "/home/nuitka-buildmaster/sandbox/local/lib/python2.7/site-
 packages/buildbot/config.py", line 162, in loadConfig
             config = MasterConfig.loadFromDict(config_dict, filename)
           File "/home/nuitka-buildmaster/sandbox/local/lib/python2.7/site-
 packages/buildbot/config.py", line 339, in loadFromDict
             config.check_single_master()
           File "/home/nuitka-buildmaster/sandbox/local/lib/python2.7/site-
 packages/buildbot/config.py", line 816, in check_single_master
             unscheduled_buildernames = set([b.name for b in
 self.builders])
         exceptions.AttributeError: 'NoneType' object has no attribute
 'name'

 }}}

 Seems error handling for this case is not there yet.

--
Ticket URL: <http://trac.buildbot.net/ticket/3637>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation