[Buildbot] #3633: Worse buildbot.tac than before

Buildbot trac trac at buildbot.net
Thu Oct 27 05:50:37 UTC 2016


#3633: Worse buildbot.tac than before
----------------------+-----------------------
Reporter:  kayhayen   |      Owner:
    Type:  undecided  |     Status:  new
Priority:  minor      |  Milestone:  undecided
 Version:  0.9.0      |   Keywords:
----------------------+-----------------------
 I have this diff, after I recreated the master with buildbot create-
 master:

 --- a/roles/buildbot-master/files/master-homedir/master/buildbot.tac
 +++ b/roles/buildbot-master/files/master-homedir/master/buildbot.tac
 @@ -3,7 +3,7 @@ import os
  from twisted.application import service
  from buildbot.master import BuildMaster

 -basedir = r'/home/nuitka-buildmaster/master'
 +basedir = '/home/nuitka-buildmaster/master'
  rotateLength = 10000000
  maxRotatedFiles = 10
  configfile = 'master.cfg'
 @@ -13,7 +13,7 @@ umask = None

  # if this is a relocatable tac file, get the directory containing the TAC
  if basedir == '.':
 -    import os.path
 +    import os
      basedir = os.path.abspath(os.path.dirname(__file__))

 The later import change is plain unnecessary, since os.path is not a
 submodule, but a variable of "os". And the first might be symptom of no
 longer properly handling strange paths with say "\" inside of them.
 Putting things as raw strings should be the better idea.

--
Ticket URL: <http://trac.buildbot.net/ticket/3633>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation


More information about the bugs mailing list