[Buildbot] #3649: GerritChangeFilter doesn't trigger a builder if a push is done without a gerrit review

[Buildbot trac]

#3649: GerritChangeFilter doesn't trigger a builder if a push is done without a
gerrit review
--------------------+--------------------
Reporter:  RockHed  |       Owner:
    Type:  defect   |      Status:  new
Priority:  major    |   Milestone:  0.8.x
 Version:  0.8.12   |  Resolution:
Keywords:  Gerrit   |
--------------------+--------------------
Changes (by sa2ajj):

 * milestone:  undecided => 0.8.x


Old description:

> I'm on 0.8.14 and If I go through the usual gerrit flow of a push
> for/branch & it's then merged into said branch, buildbot triggers a build
> just fine. However, if I push it directly into said branch, even though
> buildbot sees the change, no build is triggerred.
> my AnyBranchScheduler is set up as:
> change_filter=GerritChangeFilter(project=repo, branch="master", eventtype
> =["ref-updated", "change-merged"])
>
> and the below change was added that had no effect:
> 2016-11-29 22:45:49-0800 [-] added change Change(revision=u'e69d....',
> branch=u'master', comments=u'Gerrit: patchset(s) merged.',
> when=1480488349, category=u'ref-updated',

New description:

 I'm on 0.8.14 and If I go through the usual Gerrit flow of a push
 for/branch & it's then merged into said branch, Buildbot triggers a build
 just fine. However, if I push it directly into said branch, even though
 Buildbot sees the change, no build is triggerred.
 my !AnyBranchScheduler is set up as:
 {{{
 change_filter=GerritChangeFilter(project=repo, branch="master", eventtype
 =["ref-updated", "change-merged"])
 }}}

 and the below change was added that had no effect:
 {{{
 2016-11-29 22:45:49-0800 [-] added change Change(revision=u'e69d....',
 branch=u'master', comments=u'Gerrit: patchset(s) merged.',
 when=1480488349, category=u'ref-updated',
 }}}

--

Comment:

 I'm a bit confused: the filter you show would not handled "push
 for/branch".  Can you provide a bit more details about your setup?  A
 redacted version of your `master.cfg`?

--
Ticket URL: <http://trac.buildbot.net/ticket/3649#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation