[Buildbot] #3494: www/change_hook base broken because of isdir dependency
Buildbot trac
trac at buildbot.net
Sun Mar 20 04:46:09 UTC 2016
#3494: www/change_hook base broken because of isdir dependency
--------------------+-----------------------
Reporter: rayalan | Owner:
Type: defect | Status: new
Priority: major | Milestone: undecided
Version: master | Keywords:
--------------------+-----------------------
Earlier in the 0.9.0 series, isdir was removed from changes. See, for
example, http://trac.buildbot.net/ticket/2643. It looks like, though, that
www/hooks/base.py (line 74) still passes the argument.
Sample traceback:
{{{
2016-03-19 23:05:05-0400 [HTTPChannel,0,127.0.0.1] adding changes from web
hook
Traceback (most recent call last):
File "buildbot-core/venv/lib/python2.7/site-
packages/twisted/internet/defer.py", line 1274, in unwindGenerator
return _inlineCallbacks(None, gen, Deferred())
File "buildbot-core/venv/lib/python2.7/site-
packages/twisted/internet/defer.py", line 1128, in _inlineCallbacks
result = g.send(result)
File "buildbot-core/venv/lib/python2.7/site-
packages/buildbot/www/change_hook.py", line 149, in submitChanges
change = yield self.master.addChange(src=src, **chdict)
File "buildbot-core/venv/lib/python2.7/site-
packages/twisted/internet/defer.py", line 1274, in unwindGenerator
return _inlineCallbacks(None, gen, Deferred())
--- <exception caught here> ---
File "buildbot-core/venv/lib/python2.7/site-
packages/twisted/internet/defer.py", line 1128, in _inlineCallbacks
result = g.send(result)
File "buildbot-core/venv/lib/python2.7/site-
packages/buildbot/master.py", line 451, in addChange
changeid = yield self.data.updates.addChange(**kwargs)
File "buildbot-core/venv/lib/python2.7/site-
packages/twisted/internet/defer.py", line 1265, in unwindGenerator
gen = f(*args, **kwargs)
exceptions.TypeError: addChange() got an unexpected keyword argument
'isdir'
}}}
Two other points to consider:
1. It looks like changes/mail.py, changes/pb.py, and
test/util/scheduler.py may have some lingering dependencies as well,
depending on what the scope of this issue should be.
2. It looks like there aren't any unit tests for www_hooks_base. Should
there be?
--
Ticket URL: <http://trac.buildbot.net/ticket/3494>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation
More information about the bugs
mailing list