[Buildbot] #3439: Conflict between GoogleAuth (OAuth) and user info
Buildbot trac
trac at buildbot.net
Wed Mar 9 15:56:01 UTC 2016
#3439: Conflict between GoogleAuth (OAuth) and user info
-------------------+--------------------
Reporter: dustin | Owner:
Type: defect | Status: new
Priority: major | Milestone: 0.9.+
Version: master | Resolution:
Keywords: |
-------------------+--------------------
Comment (by jvcelak):
I'm affected by this bug as well. And I can help by sending a patch. But
I'm not sure what is the proper fix.
I'm thinkng about the following solutions:
1. The simplest one. Make the base implementation `UserInfoProviderBase`
return an empty dictionary, instead of returning an username as the
e-mail.
2. Check if there is `@` character in the username. If it is there use the
username as the e-mail. Otherwise, return an empty dictionary.
3. Pass the whole user information into `getUserInfo` and make the
implementation to decide, which parameters should be updated.
Ideas?
--
Ticket URL: <http://trac.buildbot.net/ticket/3439#comment:3>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation
More information about the bugs
mailing list