[Buildbot] #3562: Error using 'usetimestamps=False' with buildbot.changes.HgPoller

[Buildbot trac]

#3562: Error using 'usetimestamps=False' with buildbot.changes.HgPoller
----------------------+-----------------------
Reporter:  mab        |      Owner:
    Type:  undecided  |     Status:  new
Priority:  minor      |  Milestone:  undecided
 Version:  0.9.0b9    |   Keywords:  hg
----------------------+-----------------------
 When using buildbot.changes.!HgPoller() with 'usetimestamps=False' an
 'Unhandled Error' occurs:


 {{{
 Traceback (most recent call last):
   File "/home/buildmaster/venv/lib/python2.7/site-
 packages/twisted/internet/defer.py", line 393, in callback
     self._startRunCallbacks(result)
   File "/home/buildmaster/venv/lib/python2.7/site-
 packages/twisted/internet/defer.py", line 501, in _startRunCallbacks
     self._runCallbacks()
   File "/home/buildmaster/venv/lib/python2.7/site-
 packages/twisted/internet/defer.py", line 588, in _runCallbacks
     current.result = callback(current.result, *args, **kw)
   File "/home/buildmaster/venv/lib/python2.7/site-
 packages/twisted/internet/defer.py", line 1184, in gotResult
     _inlineCallbacks(r, g, deferred)
 --- <exception caught here> ---
   File "/home/buildmaster/venv/lib/python2.7/site-
 packages/twisted/internet/defer.py", line 1128, in _inlineCallbacks
     result = g.send(result)
   File "/home/buildmaster/venv/lib/python2.7/site-
 packages/buildbot/changes/hgpoller.py", line 287, in _processChanges
     when_timestamp=int(timestamp),
 exceptions.TypeError: int() argument must be a string or a number, not
 'NoneType'

 }}}


 The problem seems to be in buildbot.changes.HgPoller._processChanges():

 {{{
 ...
 when_timestamp=int(timestamp)
 ...
 }}}


 In branch 'eight' epoch2datetime() is used:


 {{{
 ...
 when_timestamp=epoch2datetime(timestamp)
 ...
 }}}

--
Ticket URL: <http://trac.buildbot.net/ticket/3562>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation