[Buildbot] #3581: LatentBuildWorker stop while starting race condition

[Buildbot trac]

#3581: LatentBuildWorker stop while starting race condition
-------------------+-------------------
Reporter:  tardyp  |      Owner:
    Type:  defect  |     Status:  new
Priority:  major   |  Milestone:  0.9.0
 Version:  master  |   Keywords:
-------------------+-------------------
 If we stop the master while starting a latent worker, we got following in
 the log.


 {{{
 2016-07-12 14:47:08+0000 [-] Weird: Got request to stop before started.
 Allowing worker to start cleanly to avoid inconsistent state
 2016-07-12 14:47:08+0000 [-] doing housekeeping for master 1
 7e989d65be2d:/var/lib/buildbot
 2016-07-12 14:47:08+0000 [-] (TCP Port 8010 Closed)
 2016-07-12 14:47:08+0000 [-] Stopping factory
 <buildbot.www.service.RotateLogSite instance at 0x7f11583e3d88>
 2016-07-12 14:47:08+0000 [-] (TCP Port 9989 Closed)
 2016-07-12 14:47:08+0000 [-] Stopping factory
 <twisted.spread.pb.PBServerFactory instance at 0x7f11589fbd88>
 }}}

 Obviously, if 9989 port is closed, the worker can never start, so we hang
 the master until start timeout.

--
Ticket URL: <http://trac.buildbot.net/ticket/3581>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation