[Buildbot] #2521: Replace deprecated method unittest.TestCase.assert_() with newer assertEqual/NotEqual

[Buildbot trac]

#2521: Replace deprecated method unittest.TestCase.assert_() with newer
assertEqual/NotEqual
-------------------------+------------------------
Reporter:  rutsky        |       Owner:
    Type:  enhancement   |      Status:  new
Priority:  major         |   Milestone:  undecided
 Version:  0.8.7p1       |  Resolution:
Keywords:  tests simple  |
-------------------------+------------------------

Comment (by rutsky):

 Looks like I never made PR that finally fixes this issue:

 {{{
 $ git grep 'assert_('
 master/buildbot/test/unit/test_changes_p4poller.py:
 self.assert_(self.changesource.last_change is None)
 master/buildbot/test/unit/test_process_build.py:
 self.assert_(('startStep', (self.workerforbuilder.worker.conn,), {})
 master/buildbot/test/unit/test_process_build.py:
 self.assert_(('interrupt', ('stop it',), {}) in step.method_calls)
 master/buildbot/test/unit/test_process_build.py:
 self.assert_(('interrupt', ('stop it',), {}) in step1.method_calls)
 master/buildbot/test/unit/test_process_build.py:
 self.assert_(step2Started[0])
 master/buildbot/test/unit/test_process_build.py:
 self.assert_(('startStep', (self.workerforbuilder.worker.conn,), {})
 master/buildbot/test/unit/test_process_build.py:
 self.assert_(b.currentStep is None)
 master/buildbot/test/unit/test_process_build.py:
 self.assert_(b._acquiringLock is not None)
 master/buildbot/test/unit/test_process_build.py:
 self.assert_(('startStep', (self.workerforbuilder.worker.conn,), {})
 master/buildbot/test/unit/test_process_build.py:
 self.assert_(b.currentStep is None)
 master/buildbot/test/unit/test_process_build.py:
 self.assert_(('interrupt', ('stop it',), {}) not in step.method_calls)
 master/buildbot/test/unit/test_process_build.py:
 self.assert_(('startStep', (self.workerforbuilder.worker.conn,), {})
 master/buildbot/test/unit/test_process_build.py:
 self.assert_(b.currentStep is None)
 master/buildbot/test/unit/test_process_build.py:
 self.assert_(('interrupt', ('stop it',), {}) not in step.method_calls)
 master/buildbot/test/unit/test_process_build.py:
 self.assert_(b.currentStep is step)
 master/buildbot/test/unit/test_process_metrics.py:
 self.assert_(metrics._get_rss() > 0)
 master/buildbot/test/unit/test_process_metrics.py:
 self.assert_(observer.log_task)
 master/buildbot/test/unit/test_process_metrics.py:
 self.assert_(observer.periodic_task)
 master/buildbot/test/unit/test_process_metrics.py:
 self.assert_(observer.log_task)
 master/buildbot/test/unit/test_process_metrics.py:
 self.assert_(observer.periodic_task)
 master/buildbot/test/unit/test_process_properties.py:        self.assert_
 ('do-tests' in self.props)
 master/buildbot/test/unit/test_steps_transfer.py:
 self.assert_(False, "No downloadFile command found")
 }}}

 It should easy to fix.

--
Ticket URL: <http://trac.buildbot.net/ticket/2521#comment:8>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation