[Buildbot] #2872: No error is reported when suppressionFile does not exist

[Buildbot trac]

#2872: No error is reported when suppressionFile does not exist
---------------------+-----------------------
Reporter:  wentasah  |       Owner:  MikeLing
    Type:  defect    |      Status:  assigned
Priority:  minor     |   Milestone:  0.8.x
 Version:            |  Resolution:
Keywords:  simple    |
---------------------+-----------------------

Comment (by MikeLing):

 Hello, I got some progress after I assign this to myself.

 Fist of all, I suppose we need add 'isfile' check around this line
 (https://github.com/buildbot/buildbot/blob/master/slave/buildslave/commands/transfer.py#L85)
 and return with a 'file doesn't exist' error.

 Then we need add a test for it in
 https://github.com/buildbot/buildbot/blob/6b883c118c37709835bfb37e69af4990796843fe/master/buildbot/test/regressions/test_steps_shell_WarningCountingShellCommand.py.
 Is that right?

 But my question is how to init WarningCountingShellCommand if I want to
 add suppression with suppressionFile. Something like " w =
 WarningCountingShellCommand suppressionFile='impossiblefilename.txt')"
 doesn't work because it told me:

 > exceptions.AttributeError: 'NoneType' object has no attribute
 'getSlaveCommandVersion'

 Could you tell me what should I do next? Thank you very much! :)

--
Ticket URL: <http://trac.buildbot.net/ticket/2872#comment:5>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation