[Buildbot] #3649: GerritChangeFilter doesn't trigger a builder if a push is done without a gerrit review

Buildbot trac trac at buildbot.net
Fri Dec 16 18:43:39 UTC 2016


#3649: GerritChangeFilter doesn't trigger a builder if a push is done without a
gerrit review
--------------------+--------------------
Reporter:  RockHed  |       Owner:
    Type:  defect   |      Status:  new
Priority:  major    |   Milestone:  0.8.x
 Version:  0.8.12   |  Resolution:
Keywords:  Gerrit   |
--------------------+--------------------

Comment (by RockHed):

 Sorry for the delay -- no, this is still a problem.  Essentially, here's
 master.cfg:
 repo="blah"
 c["change_source"].append(GerritChangeSource(GERRIT_SERVER, GERRIT_USER,
 handled_events=["patchset-created", "change-abandoned", "change-restored",
 "change-merged", "ref-updated"]))
 c["schedulers"].append(AnyBranchScheduler(
                          name="tester",
                          change_filter=GerritChangeFilter(project=repo,
 branch="master", eventtype=["ref-updated", "change-merged"]),
                          treeStableTimer=5*60,
                          builderNames=["{0} reconfigure".format(repo)]
                      ))

 and here's the incoming event:

 2016-12-16 10:31:30-0800 [-] gerrit:
 {"submitter":{"name":"...REDACTED..."project":"blah"},"type":"ref-
 updated","eventCreatedOn":1481913090}

 2016-12-16 10:31:30-0800 [-] added change Change(revision=u'...',
 who=u'RockHed'...branch=u'master', comments=u'Gerrit: patchset(s)
 merged.', when=1481913090, category=u'ref-updated', project=u'blah', ....

 So the incoming change is definitely recognized, but the builder in
 builderNames did not seem to get kicked off.

--
Ticket URL: <http://trac.buildbot.net/ticket/3649#comment:4>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation


More information about the bugs mailing list