[Buildbot] #3656: duplicate worker use case is broken

[Buildbot trac]

#3656: duplicate worker use case is broken
---------------------+-------------------
Reporter:  tardyp    |      Owner:
    Type:  defect    |     Status:  new
Priority:  critical  |  Milestone:  0.9.3
 Version:  0.9.0     |   Keywords:
---------------------+-------------------
 2016-12-14 11:58:54+0100 [Broker,34,127.0.0.1] worker 'worker0' attaching
 from IPv4Address(TCP, '127.0.0.1', 65520)
 2016-12-14 11:58:54+0100 [Broker,34,127.0.0.1] Got duplication connection
 from 'worker0' starting arbitration procedure
 2016-12-14 11:58:54+0100 [Broker,30,127.0.0.1] Got error while trying to
 ping connected worker worker0:rejecting duplicate worker
 2016-12-14 11:58:54+0100 [Broker,30,127.0.0.1] Old connection for
 'worker0' was lost, accepting new
 2016-12-14 11:58:54+0100 [Broker,30,127.0.0.1] Worker.detached(worker0)
 2016-12-14 11:58:54+0100 [Broker,30,127.0.0.1] releaseLocks(<Worker
 u'worker0'>): []
 2016-12-14 11:58:54+0100 [Broker,30,127.0.0.1] Worker worker0 detached
 from runtests
 2016-12-14 11:58:54+0100 [Broker,34,127.0.0.1] Got workerinfo from
 'worker0'
 2016-12-14 11:58:54+0100 [-] False
 2016-12-14 11:58:54+0100 [-] from a running build; this is a serious error
 - please file a bug at http://buildbot.net
         Traceback (most recent call last):
           File "/Users/ptardy/dev/bb/buildbot/sandbox/lib/python2.7/site-
 packages/twisted/internet/defer.py", line 1355, in gotResult
             _inlineCallbacks(r, g, deferred)
           File "/Users/ptardy/dev/bb/buildbot/sandbox/lib/python2.7/site-
 packages/twisted/internet/defer.py", line 1299, in _inlineCallbacks
             result = g.send(result)
           File
 "/Users/ptardy/dev/bb/buildbot/master/buildbot/process/build.py", line
 298, in startBuild
             yield self.buildPreparationFailure(ready_or_failure,
 "worker_prepare")
           File "/Users/ptardy/dev/bb/buildbot/sandbox/lib/python2.7/site-
 packages/twisted/internet/defer.py", line 1445, in unwindGenerator
             return _inlineCallbacks(None, gen, Deferred())
         --- <exception caught here> ---
           File "/Users/ptardy/dev/bb/buildbot/sandbox/lib/python2.7/site-
 packages/twisted/internet/defer.py", line 1299, in _inlineCallbacks
             result = g.send(result)
           File
 "/Users/ptardy/dev/bb/buildbot/master/buildbot/process/build.py", line
 352, in buildPreparationFailure
             self.workerforbuilder.worker.putInQuarantine()
         exceptions.AttributeError: 'NoneType' object has no attribute
 'putInQuarantine'

 This is because of
 https://github.com/buildbot/buildbot/commit/7e3003d241072f18d2845b487cd6cdf7fd364960

 The RuntimeError is caught means it will stop the two workers, which will
 in turn kill a build.

--
Ticket URL: <http://trac.buildbot.net/ticket/3656>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation