[Buildbot] #3650: MailNotifier handles build result RETRY inconsistently

[Buildbot trac]

#3650: MailNotifier handles build result RETRY inconsistently
----------------------+-----------------------
Reporter:  dcoshea    |      Owner:
    Type:  undecided  |     Status:  new
Priority:  major      |  Milestone:  undecided
 Version:  0.8.12     |   Keywords:  mail
----------------------+-----------------------
 In both 0.8.12 and 0.9.1, `MailNotifier` doesn't seem to handle the
 `RETRY` result consistently.

 If you consider the result `FAILURE`, you can get `MailNotifier` to send
 email for every build that has that result, or only when the result
 changes to or from that result.

 For `RETRY` on the other hand, on 0.8.12 at least an attempt will be made
 to send an email if the `mode` includes `change` and the status changes to
 `RETRY` (the attempt fails on 0.8.12 - I'll file a separate bug for that),
 but it doesn't seem possible to request that an email be sent for every
 single build whose result is `RETRY` - `mail.py` doesn't seem to know that
 `RETRY` exists.  I tried using `mode = "all"` in both 0.8.12 and 0.9.1 and
 didn't get email when I repeatedly disconnected the slave/worker during
 builds.

 I think that this issue is significant, because slaves/workers going
 offline is unexpected (at least in my environment on a LAN), and whilst I
 gather that I can configure the master to notify me when a slave/worker
 goes offline, I'd actually like to be notified about the build that was
 interrupted and get a URL for viewing the partial results of that build.

--
Ticket URL: <http://trac.buildbot.net/ticket/3650>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation