[Buildbot] #3597: BitbucketPullrequestPoller thinks all pull requests are new

Buildbot trac trac at buildbot.net
Sat Aug 20 06:49:45 UTC 2016


#3597: BitbucketPullrequestPoller thinks all pull requests are new
-----------------------+-----------------------
Reporter:  sambristow  |      Owner:
    Type:  defect      |     Status:  new
Priority:  major       |  Milestone:  undecided
 Version:  master      |   Keywords:
-----------------------+-----------------------
 The `BitbucketPullrequestPoller` treats all pull requests it sees as new,
 even if we have already fetched and built the corresponding change set.

 In the `_processChanges` method the hash of the incoming revision is
 compared against the hash of the current revision stored in the database.
 At this point we only have the ''short'' hash of the incoming change set
 and it is compared against the ''full'' hash of the current revision from
 the database. This comparison fails every time and the pull request is
 treated as though it has been updated and is rebuilt.

 I have a working fix which I will push up soon - I'm just updating the
 test suite to properly verify the behaviour.

--
Ticket URL: <http://trac.buildbot.net/ticket/3597>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation


More information about the bugs mailing list