[Buildbot] #3542: consider users.srcs for email address lookup in MailNotifier

Buildbot trac trac at buildbot.net
Thu Apr 28 13:57:27 UTC 2016

#3542: consider users.srcs for email address lookup in MailNotifier
Reporter:  reddot  |      Owner:
    Type:  defect  |     Status:  new
Priority:  major   |  Milestone:  undecided
 Version:  0.8.12  |   Keywords:  mail
 I'm trying to implement fetch of author emails for perforce source
 control. To understand how this should work I'm refering to GitPoller
 implementation (it's noted in documentation that git users are translated
 to user objects). I've assumed that creating user objects from git changes
 should provide author emails for MailNotifier without the need of special
 lookup function. However I found that doesn't work and it seems point is
 that MailNotifier code looking for 'email' attribute of user object where
 GitPoller stores email in 'git' attribute. Simply changing:

     return users.getBuildContacts(self.master, build, ['email'])


     return users.getBuildContacts(self.master, build, ['email'] +

 do the trick. Could this change be incorporated to
 Buildbot upstream?

Ticket URL: <http://trac.buildbot.net/ticket/3542>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

More information about the bugs mailing list