[Buildbot] #3522: Gerrit Reporter summaryCB does not accept deferreds

[Buildbot trac]

#3522: Gerrit Reporter summaryCB does not accept deferreds
-----------------------+-----------------------
Reporter:  ryansydnor  |      Owner:
    Type:  defect      |     Status:  new
Priority:  minor       |  Milestone:  undecided
 Version:  master      |   Keywords:
-----------------------+-----------------------
 I am trying to pull extra information about a particular build (steps, in
 this case). I am not able to yield getDetailsForBuild(master, build,
 wantSteps=True) because I cannot make my callback a
 @defer.inlineCallbacks.

 I see a couple of solutions:

 1. Make sendBuildSetSummary a @defer.inlineCallbacks and yield the call to
 self.summaryCB, which would break backwards compatibility
 2. Take a new "summaryCBDeferred" in the constructor. Do the same as
 above, if specified. This would retain backwards compatibility
 3. Take "wantSteps", "wantLogs", "wantX" into the constructor, pass those
 through to the "buildsetComplete" call to "getDetailsForBuildset" so the
 consumer is none the wiser. This will retain backwards compatibility.

--
Ticket URL: <http://trac.buildbot.net/ticket/3522>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation