[Buildbot] #3321: make compare_attrs type consistent

Buildbot trac trac at buildbot.net
Thu Oct 29 01:50:02 UTC 2015

#3321: make compare_attrs type consistent
Reporter:  ewong      |       Owner:  ewong
    Type:  undecided  |      Status:  assigned
Priority:  minor      |   Milestone:  undecided
 Version:  0.8.12     |  Resolution:
Keywords:             |

Comment (by dustin):

 Well, this certainly shouldn't break anything, but I don't think it will
 require much more than changing some `()` to `[]`.  The
 `accumulateTaskList` function comes from Twisted, so we can't rename it.
 It will do the trick, even if the name is funny.

 Misha is suggesting tuples because they help avoid the temptation of
 mutating a list.

Ticket URL: <http://trac.buildbot.net/ticket/3321#comment:5>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

More information about the bugs mailing list