[Buildbot] #2878: Windows escaping seem to produce problems

Buildbot trac trac at buildbot.net
Thu Mar 19 19:44:36 UTC 2015


#2878: Windows escaping seem to produce problems
--------------------+--------------------
Reporter:  sa2ajj   |       Owner:
    Type:  defect   |      Status:  new
Priority:  major    |   Milestone:  0.9.+
 Version:  0.8.9    |  Resolution:
Keywords:  windows  |
--------------------+--------------------

Comment (by JustAMan):

 I suggest we move Buildbot process spawning code to subprocess.
 Both issues (watching for stdio and waiting for finish) are almost easy.

 We have SCons-based build system where I worked on refactoring how
 processes are spawned, and this system "tee's" process output to a
 separate file and to console without much problem. The same goes to
 waiting for process to finish or killing the whole tree.

 I can talk to our system architect who's right now working on open-
 sourcing it if we can move this process handling code to a subpackage. Or
 maybe I can just copy-paste it to Buildbot as it's about 15K overall, and
 is regularly tested on Windows, Linux and MacOS (and now it works on
 FreeBSD as well).

 If that won't suit Buildbot community I suggest we at least move to
 subprocess.list2cmdline() function instead of ugly manual quoting.

--
Ticket URL: <http://trac.buildbot.net/ticket/2878#comment:12>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation


More information about the bugs mailing list