[Buildbot] #3271: 0.8.12 breaks back compatibility with github change_hook

Buildbot trac trac at buildbot.net
Sat Jun 6 03:37:19 UTC 2015


#3271: 0.8.12 breaks back compatibility with github change_hook
----------------------+-----------------------
Reporter:  skelly     |      Owner:
    Type:  undecided  |     Status:  new
Priority:  major      |  Milestone:  undecided
 Version:  0.8.12     |   Keywords:
----------------------+-----------------------
 Prior to f3a47a18eba449994c136fa9daa93a9554907c28, the github key in
 `change_hook_dialects` didn't care about the value. The docs set the value
 to `True` and we copied that example.

 When upgrading to 0.8.12, that value now matters. If it is not None, the
 value is used as is and an exception is raised on line 222 when the get
 attribute is used. For a boolean, there is no get attribute. I switched
 the value in our config to None and all is happy.

--
Ticket URL: <http://trac.buildbot.net/ticket/3271>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation


More information about the bugs mailing list