[Buildbot] #3321: make compare_attrs type consistent

Buildbot trac trac at buildbot.net
Sat Jul 25 04:52:04 UTC 2015

#3321: make compare_attrs type consistent
Reporter:  ewong      |      Owner:
    Type:  undecided  |     Status:  new
Priority:  major      |  Milestone:  undecided
 Version:  0.8.12     |   Keywords:
 Currently, in 0.8.12 in some part of the code, compare_attrs is a tuple
 and in other parts, it's a list.

 For consistency's sake, perhaps it's better to make them the same
 type throughout the code?

 As Pierre mentioned on the list:
   "Each class should declare the attributes they care about, and the
 ComparableMixin should gather and concatenate everything."

Ticket URL: <http://trac.buildbot.net/ticket/3321>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

More information about the bugs mailing list