[Buildbot] #420: slash not escaped in url links when builder name contains slash inside

[Buildbot trac]

#420: slash not escaped in url links when builder name contains slash inside
-------------------+-----------------------
Reporter:  arekm   |       Owner:  djmitche
    Type:  defect  |      Status:  closed
Priority:  minor   |   Milestone:  0.7.10
 Version:  0.7.9   |  Resolution:  fixed
Keywords:  review  |
-------------------+-----------------------

Comment (by ido):

 Hi Dustin, long time no see, just wanted to reopen this briefly since I
 found unescaped/unquoted slashes in the /buildslaves page in the
 builder_column that lists the builders that use each buildslave in the
 list:

 There's an issue in the /buildslaves page.

 Backend =
 https://github.com/buildbot/buildbot/blob/eight/master/buildbot/status/web/slaves.py

 Template =
 https://github.com/buildbot/buildbot/blob/eight/master/buildbot/status/web/templates/buildslaves.html

 I've only confirmed the issue with 0.8.10, not with the nine branch (I am
 only running eight).

 Steps to replicate:
 1. Create a buildslave.
 2. Create a builder with a slash (/) in its name, e.g. "abc/xyz/123".
 3. Go to the buildbot master's web, click on the "Buildslaves" link in the
 header, which in my case takes you to http://localhost:8010/buildslaves
 4. Click on the builder's link (abc/xyz/123) in the appropriate
 buildslave's row on that page.
 5. It will take you to http://localhost:8010/builders/abc/xyz/123 (rather
 than http://localhost:8010/builders/abc%2Fxyz%2F123), resulting in a 404
 No Such Resource error when you click on the builder column link from the
 `/buildslaves` page.  This is because `b.path_to_builder` is not used to
 generate the links to the builder's page in `/buildslaves`.

--
Ticket URL: <http://trac.buildbot.net/ticket/420#comment:4>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation