[Buildbot] #3197: GerritChangeSource fails with commit messages longer than 1024 characters

[Buildbot trac]

#3197: GerritChangeSource fails with commit messages longer than 1024 characters
-------------------+------------------------
Reporter:  ims     |       Owner:
    Type:  defect  |      Status:  new
Priority:  major   |   Milestone:  undecided
 Version:  0.8.10  |  Resolution:
Keywords:  gerrit  |
-------------------+------------------------
Changes (by sa2ajj):

 * keywords:   => gerrit


Old description:

> `GerritChangeSource` adds all change event values received from Gerrit as
> change properties, one of which is the commit message
> (`event.change.commitMessage`). In the schema as included in Buildbot
> 0.8.10 change property values are limited to 1024 characters.
>
> At least when using PostgreSQL, insertion of properties fails and the
> received event is ignored.
>
> {{{
> … error adding change from GerritChangeSource
> …
> sqlalchemy.exc.DataError: (DataError) value too long for type character
> varying(1024)
> 'INSERT INTO change_properties (changeid, …
> }}}
>
> The field `change_properties.property_value` should be changed to `TEXT`
> as already done for `buildset_properties.property_value` and
> `changes.comments` in ticket 2367.

New description:

 `GerritChangeSource` adds all change event values received from Gerrit as
 change properties, one of which is the commit message
 (`event.change.commitMessage`). In the schema as included in Buildbot
 0.8.10 change property values are limited to 1024 characters.

 At least when using PostgreSQL, insertion of properties fails and the
 received event is ignored.

 {{{
 … error adding change from GerritChangeSource
 …
 sqlalchemy.exc.DataError: (DataError) value too long for type character
 varying(1024)
 'INSERT INTO change_properties (changeid, …
 }}}

 The field `change_properties.property_value` should be changed to `TEXT`
 as already done for `buildset_properties.property_value` and
 `changes.comments` in ticket #2367.

--

--
Ticket URL: <http://trac.buildbot.net/ticket/3197#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation