[Buildbot] #2676: be consistent - addXxx or newXxx? (was: [nine] be consistent - addXxx or newXxx?)
Buildbot trac
trac at buildbot.net
Sun Feb 8 15:44:21 UTC 2015
#2676: be consistent - addXxx or newXxx?
------------------------+--------------------
Reporter: dustin | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone: 0.9.0
Version: | Resolution:
Keywords: simple |
------------------------+--------------------
Changes (by dustin):
* keywords: => simple
Comment:
{{{
dustin at euclid ~/code/buildbot/t/buildbot [bug3058] $ grep 'def new[A-Z]'
master/buildbot/db/*.py
dustin at euclid ~/code/buildbot/t/buildbot [bug3058] $ grep 'def new[A-Z]'
master/buildbot/data/*.py
master/buildbot/data/builds.py: def newBuild(self, builderid,
buildrequestid, buildslaveid):
master/buildbot/data/logs.py: def newLog(self, stepid, name, type):
master/buildbot/data/steps.py: def newStep(self, buildid, name):
}}}
So, let's standardize on `add` and just rename those three methods.
--
Ticket URL: <http://trac.buildbot.net/ticket/2676#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation
More information about the bugs
mailing list