[Buildbot] #3250: RemoveDirectory step does not take a timeout argument, and the default (4 minutes) is too short

[Buildbot trac]

#3250: RemoveDirectory step does not take a timeout argument, and the default (4
minutes) is too short
------------------------------------+------------------------
Reporter:  ccrome                   |       Owner:
    Type:  undecided                |      Status:  new
Priority:  major                    |   Milestone:  undecided
 Version:  0.8.10                   |  Resolution:
Keywords:  RemoveDirectory timeout  |
------------------------------------+------------------------

Comment (by ccrome):

 Here's my whack at a patch to buildbot/steps/slave.py

 This patch at least passes a reconfig with the added 'timeout' argument to
 RemoveDirectory.  Not sure if it works yet...

  self.addStep(RemoveDirectory(dir="build", doStepIf=IsFullBuild,
 timeout=20*60))


 173c173
 <     def __init__(self, dir, timeout=None, maxTime=None, **kwargs):
 ---
 >     def __init__(self, dir, **kwargs):
 176,177d175
 <         self.timeout = timeout
 <         self.maxTime = maxTime
 184,190c182
 <         args = {'dir' : self.dir }
 <         if self.timeout:
 <             args['timeout'] = self.timeout
 <         if self.maxTime:
 <             args['maxTime'] = self.maxTime
 <
 <         cmd = buildstep.RemoteCommand('rmdir', args)
 ---
 >         cmd = buildstep.RemoteCommand('rmdir', {'dir': self.dir })

--
Ticket URL: <http://trac.buildbot.net/ticket/3250#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation