[Buildbot] #2885: Windows: rmdirRecursive() fails if a contained file is opened

Buildbot trac trac at buildbot.net
Thu Sep 11 20:22:49 UTC 2014


#2885: Windows: rmdirRecursive() fails if a contained file is opened
--------------------+------------------------
Reporter:  dl       |       Owner:
    Type:  defect   |      Status:  new
Priority:  major    |   Milestone:  undecided
 Version:  0.8.9    |  Resolution:
Keywords:  windows  |
--------------------+------------------------

Comment (by dustin):

 Returning to the topic of the bug, I totally agree that additional testing
 would be great.  I'm not sure how best to test the interaction with virus
 checkers, for example.  We've also had a hell of a time getting donated
 Windows systems to stay up and functional, so we don't currently have any
 windows coverage.

 Regarding the patch, I like the form -- there's really no point in
 retrying individual files, rather than retrying the whole remove a few
 times.

 There's still the issue of using time.sleep, though -- that will cause the
 entire buildslave process to stop, which means any other commands that are
 in progress at the time will freeze.  It'd be better to use
 `reactor.callLater`, which in turn requires `rmdirRecursive` to return a
 `Deferred`.

--
Ticket URL: <http://trac.buildbot.net/ticket/2885#comment:12>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation


More information about the bugs mailing list