[Buildbot] #3017: Running SVN step without SVN gives troubles

[Buildbot trac]

#3017: Running SVN step without SVN gives troubles
-------------------+-----------------------
Reporter:  Ben     |      Owner:
    Type:  defect  |     Status:  new
Priority:  minor   |  Milestone:  undecided
 Version:  master  |   Keywords:
-------------------+-----------------------
 The first exception is to be expected (somehow), the second one is pretty
 alarming ...

 {{{
 2014-11-10 14:49:42+0100 [-] <RemoteShellCommand '['svn', '--version']'>:
 RemoteCommand.run [0]
 2014-11-10 14:49:42+0100 [-] command '['svn', '--version']' in dir 'build'
 2014-11-10 14:49:42+0100 [Broker,1,192.168.201.227] <RemoteShellCommand
 '['svn', '--version']'> rc=1
 2014-11-10 14:49:42+0100 [-] BuildStep.failed; traceback follows
         Traceback (most recent call last):
           File "/home/benoit/buildbot/openvas/venv/local/lib/python2.7
 /site-packages/twisted/internet/defer.py", line 577, in _runCallbacks
             current.result = callback(current.result, *args, **kw)
           File "/home/benoit/buildbot/openvas/venv/local/lib/python2.7
 /site-packages/twisted/internet/defer.py", line 1155, in gotResult
             _inlineCallbacks(r, g, deferred)
           File "/home/benoit/buildbot/openvas/venv/local/lib/python2.7
 /site-packages/twisted/internet/defer.py", line 1097, in _inlineCallbacks
             result = result.throwExceptionIntoGenerator(g)
           File "/home/benoit/buildbot/openvas/venv/local/lib/python2.7
 /site-packages/twisted/python/failure.py", line 389, in
 throwExceptionIntoGenerator
             return g.throw(self.type, self.value, self.tb)
         --- <exception caught here> ---
           File
 "/home/benoit/buildbot/buildbot/master/buildbot/process/buildstep.py",
 line 461, in startStep
             results = yield self.run()
           File "/home/benoit/buildbot/openvas/venv/local/lib/python2.7
 /site-packages/twisted/internet/defer.py", line 1099, in _inlineCallbacks
             result = g.send(result)
           File
 "/home/benoit/buildbot/buildbot/master/buildbot/process/buildstep.py",
 line 576, in run
             results = yield self._start_deferred
           File "/home/benoit/buildbot/openvas/venv/local/lib/python2.7
 /site-packages/twisted/internet/defer.py", line 577, in _runCallbacks
             current.result = callback(current.result, *args, **kw)
           File
 "/home/benoit/buildbot/buildbot/master/buildbot/steps/source/svn.py", line
 90, in checkInstall
             raise BuildSlaveTooOldError("SVN is not installed on slave")
         buildbot.interfaces.BuildSlaveTooOldError: SVN is not installed on
 slave

 2014-11-10 14:49:43+0100 [-] addCompleteLog(err.text)
 2014-11-10 14:49:43+0100 [-] from debounced function:
         Traceback (most recent call last):
           File "/home/benoit/buildbot/openvas/venv/local/lib/python2.7
 /site-packages/twisted/internet/base.py", line 824, in runUntilCurrent
             call.func(*call.args, **call.kw)
           File
 "/home/benoit/buildbot/buildbot/master/buildbot/util/debounce.py", line
 68, in invoke
             d = defer.maybeDeferred(self.function)
           File "/home/benoit/buildbot/openvas/venv/local/lib/python2.7
 /site-packages/twisted/internet/defer.py", line 139, in maybeDeferred
             result = f(*args, **kw)
           File "/home/benoit/buildbot/openvas/venv/local/lib/python2.7
 /site-packages/twisted/internet/defer.py", line 1237, in unwindGenerator
             return _inlineCallbacks(None, gen, Deferred())
         --- <exception caught here> ---
           File "/home/benoit/buildbot/openvas/venv/local/lib/python2.7
 /site-packages/twisted/internet/defer.py", line 1099, in _inlineCallbacks
             result = g.send(result)
           File
 "/home/benoit/buildbot/buildbot/master/buildbot/process/buildstep.py",
 line 379, in updateSummary
             summary = yield self.getResultSummary()
           File
 "/home/benoit/buildbot/buildbot/master/buildbot/process/buildstep.py",
 line 366, in getResultSummary
             if self.results != SUCCESS:
         exceptions.AttributeError: 'SVN' object has no attribute 'results'
 }}}

--
Ticket URL: <http://trac.buildbot.net/ticket/3017>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation