[Buildbot] #2375: SVN._sourcedirIsUpdatable checks for locale-dependant string and fails on French and Norvegian

[Buildbot trac]

#2375: SVN._sourcedirIsUpdatable checks for locale-dependant string and fails on
French and Norvegian
--------------------+---------------------
Reporter:  Quentin  |       Owner:
    Type:  defect   |      Status:  closed
Priority:  minor    |   Milestone:  0.8.9
 Version:  0.8.7    |  Resolution:  fixed
Keywords:           |
--------------------+---------------------
Changes (by dustin):

 * status:  reopened => closed
 * resolution:   => fixed


Old description:

> `svn info` outputs information about the current repository, which
> includes this line: `URL: svn://`. SVN._sourcedirIsUpdatable()
> [https://github.com/buildbot/buildbot/blob/master/master/buildbot/steps/source/svn.py#L248
> checks] that this URL corresponds to the actual URL, and uses this regex:
> `^URL:s*(.*?)s*$`.
>
> Unfortunately, in French and Norvegian, this doesn't work since the
> respectly use "URL : %s
> " and "Nettadresse: %s
> " as you can see in the
> [https://svn.apache.org/repos/asf/subversion/trunk/subversion/po/ po
> files]. I had to switch to an en_US locale to make the "updatable check"
> work.
>
> Thanks.

New description:

 `svn info` outputs information about the current repository, which
 includes this line: `URL: svn://`. SVN._sourcedirIsUpdatable()
 [https://github.com/buildbot/buildbot/blob/master/master/buildbot/steps/source/svn.py#L248
 checks] that this URL corresponds to the actual URL, and uses this regex:
 `^URL:s*(.*?)s*$`.

 Unfortunately, in French and Norvegian, this doesn't work since the
 respectly use "URL : %s
 " and "Nettadresse: %s
 " as you can see in the
 [https://svn.apache.org/repos/asf/subversion/trunk/subversion/po/ po
 files]. I had to switch to an en_US locale to make the "updatable check"
 work.

 Thanks.

--

Comment:

 Ah, but it *was* fixed in 1e5c281380b267775c14ab53a3153f848286bd35!

--
Ticket URL: <http://trac.buildbot.net/ticket/2375#comment:6>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation